From: Ben Dooks <ben-linux@fluff.org>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: wookey@wookware.org, linux-mtd@lists.infradead.org,
David.Woodhouse@intel.com, ben-linux@fluff.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] nand/s3c2410: s3c2410_nand_setrate(): use correct macros for 2412/2440
Date: Mon, 8 Jun 2009 12:20:02 +0100 [thread overview]
Message-ID: <20090608112002.GB31034@fluff.org.uk> (raw)
In-Reply-To: <1244379863-23581-1-git-send-email-jacmet@sunsite.dk>
On Sun, Jun 07, 2009 at 03:04:22PM +0200, Peter Korsgaard wrote:
> Use the correct S3C2440_NFCONF_* macros for the mask for the 2412/2440
> variants instead of the 2410 ones which use wrong bit positions.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/mtd/nand/s3c2410.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
> index 89b7905..01a105e 100644
> --- a/drivers/mtd/nand/s3c2410.c
> +++ b/drivers/mtd/nand/s3c2410.c
> @@ -253,9 +253,9 @@ static int s3c2410_nand_setrate(struct s3c2410_nand_info *info)
>
> case TYPE_S3C2440:
> case TYPE_S3C2412:
> - mask = (S3C2410_NFCONF_TACLS(tacls_max - 1) |
> - S3C2410_NFCONF_TWRPH0(7) |
> - S3C2410_NFCONF_TWRPH1(7));
> + mask = (S3C2440_NFCONF_TACLS(tacls_max - 1) |
> + S3C2440_NFCONF_TWRPH0(7) |
> + S3C2440_NFCONF_TWRPH1(7));
>
> set = S3C2440_NFCONF_TACLS(tacls - 1);
> set |= S3C2440_NFCONF_TWRPH0(twrph0 - 1);
> --
> 1.6.2
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2009-06-08 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 13:04 [PATCH] nand/s3c2410: s3c2410_nand_setrate(): use correct macros for 2412/2440 Peter Korsgaard
2009-06-07 13:04 ` [PATCH] mtd/nand: s3c6400 support for s3c2410 driver Peter Korsgaard
2009-06-08 11:11 ` Ben Dooks
2009-06-08 11:41 ` David Woodhouse
2009-06-08 5:28 ` [PATCH] nand/s3c2410: s3c2410_nand_setrate(): use correct macros for 2412/2440 Artem Bityutskiy
2009-06-08 5:38 ` Peter Korsgaard
2009-06-08 5:47 ` Artem Bityutskiy
2009-06-08 6:32 ` Peter Korsgaard
2009-06-08 6:41 ` Artem Bityutskiy
2009-06-08 7:51 ` David Woodhouse
2009-06-08 7:54 ` Peter Korsgaard
2009-06-08 11:20 ` Ben Dooks [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-03 11:46 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608112002.GB31034@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=David.Woodhouse@intel.com \
--cc=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-mtd@lists.infradead.org \
--cc=wookey@wookware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox