public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] MTD: enable partition parser in the default list when selected
@ 2009-06-22  9:27 Florian Fainelli
  2009-06-22 12:33 ` Mike Frysinger
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2009-06-22  9:27 UTC (permalink / raw)
  To: linux-mtd; +Cc: David Woodhouse

This patch makes the physmap driver use the partition parsers that
we enable in the kernel configuration as the list of partition parsers
to use when probing the flash chip.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index 29a9011..2095b60 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -80,7 +80,16 @@ static const char *rom_probe_types[] = {
 					"map_rom",
 					NULL };
 #ifdef CONFIG_MTD_PARTITIONS
-static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL };
+static const char *part_probe_types[] = {
+#ifdef CONFIG_MTD_CMDLINE_PARTS
+	"cmdlinepart",
+#elif defined CONFIG_MTD_REDBOOT_PARTS
+	"RedBoot",
+#elif defined CONFIG_MTD_AR7_PARTS
+	"ar7part",
+#endif
+	NULL
+};
 #endif
 
 static int physmap_flash_probe(struct platform_device *dev)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MTD: enable partition parser in the default list when selected
  2009-06-22  9:27 [PATCH] MTD: enable partition parser in the default list when selected Florian Fainelli
@ 2009-06-22 12:33 ` Mike Frysinger
  2009-06-22 12:56   ` Florian Fainelli
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2009-06-22 12:33 UTC (permalink / raw)
  To: Florian Fainelli; +Cc: David Woodhouse, linux-mtd

On Mon, Jun 22, 2009 at 05:27, Florian Fainelli wrote:
>  #ifdef CONFIG_MTD_PARTITIONS
> -static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL };
> +static const char *part_probe_types[] = {
> +#ifdef CONFIG_MTD_CMDLINE_PARTS
> +       "cmdlinepart",
> +#elif defined CONFIG_MTD_REDBOOT_PARTS
> +       "RedBoot",
> +#elif defined CONFIG_MTD_AR7_PARTS
> +       "ar7part",
> +#endif
> +       NULL
> +};
>  #endif

you just broke systems that have both cmdline and redboot enabled
-mike

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MTD: enable partition parser in the default list when selected
  2009-06-22 12:33 ` Mike Frysinger
@ 2009-06-22 12:56   ` Florian Fainelli
  0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2009-06-22 12:56 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: David Woodhouse, linux-mtd

Le Monday 22 June 2009 14:33:22 Mike Frysinger, vous avez écrit :
> On Mon, Jun 22, 2009 at 05:27, Florian Fainelli wrote:
> >  #ifdef CONFIG_MTD_PARTITIONS
> > -static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL
> > }; +static const char *part_probe_types[] = {
> > +#ifdef CONFIG_MTD_CMDLINE_PARTS
> > +       "cmdlinepart",
> > +#elif defined CONFIG_MTD_REDBOOT_PARTS
> > +       "RedBoot",
> > +#elif defined CONFIG_MTD_AR7_PARTS
> > +       "ar7part",
> > +#endif
> > +       NULL
> > +};
> >  #endif
>
> you just broke systems that have both cmdline and redboot enabled
> -mike

Right, let me respin that one.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-06-22 12:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-22  9:27 [PATCH] MTD: enable partition parser in the default list when selected Florian Fainelli
2009-06-22 12:33 ` Mike Frysinger
2009-06-22 12:56   ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox