From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from buzzloop.caiaq.de ([212.112.241.133]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1MMOCF-0001SF-2F for linux-mtd@lists.infradead.org; Thu, 02 Jul 2009 15:28:15 +0000 Date: Thu, 2 Jul 2009 17:27:30 +0200 From: Daniel Mack To: Artem Bityutskiy Subject: Re: [PATCH] ubifs: allow more than one volume to be mounted Message-ID: <20090702152730.GJ18340@buzzloop.caiaq.de> References: <1246547747-13366-1-git-send-email-daniel@caiaq.de> <4A4CCF99.30104@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A4CCF99.30104@gmail.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Adrian Hunter List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jul 02, 2009 at 06:17:45PM +0300, Artem Bityutskiy wrote: > Daniel Mack wrote: >> UBIFS uses a bdi device per volume, but does not care to hand out unique >> names to each of them. This causes an error when trying to mount more >> than one volumes. >> >> [ 239.277407] kobject_add_internal failed for ubifs with -EEXIST, don't try to register things with the same name in the same directory. >> [ 239.289618] [] (unwind_backtrace+0x0/0xdc) from [] (kobject_add_internal+0x188/0x1b8) >> [ 239.299445] [] (kobject_add_internal+0x188/0x1b8) from [] (kobject_add+0x48/0x5c) >> [ 239.308896] [] (kobject_add+0x48/0x5c) from [] (device_add+0xac/0x510) >> [ 239.317392] [] (device_add+0xac/0x510) from [] (device_create_vargs+0x70/0xa4) >> [ 239.326589] [] (device_create_vargs+0x70/0xa4) from [] (bdi_register+0x44/0x64) >> [ 239.335854] [] (bdi_register+0x44/0x64) from [] (ubifs_get_sb+0x3c8/0x10cc) >> [ 239.344769] [] (ubifs_get_sb+0x3c8/0x10cc) from [] (vfs_kern_mount+0x50/0xa8) >> [ 239.353867] [] (vfs_kern_mount+0x50/0xa8) from [] (do_kern_mount+0x34/0xd0) >> [ 239.362799] [] (do_kern_mount+0x34/0xd0) from [] (do_mount+0x644/0x6b4) >> [ 239.371377] [] (do_mount+0x644/0x6b4) from [] (sys_mount+0x84/0xcc) >> [ 239.379538] [] (sys_mount+0x84/0xcc) from [] (ret_fast_syscall+0x0/0x2c) >> >> Append the UBI volume and device ID to avoid that. >> >> Signed-off-by: Daniel Mack >> Cc: Artem Bityutskiy >> Cc: Adrian Hunter >> Cc: linux-mtd@lists.infradead.org > > Thanks, I'll look at this tomorrow and try to sent it to Linus > ASAP. Btw - Adrian Hunter's email in MAINTAINERS seems to be outdated: : host mx1.nokia.com[192.100.122.228] said: 550 5.1.1 ... User unknown (in reply to RCPT TO command)