From: Florian Fainelli <florian@openwrt.org>
To: linux-mtd@lists.infradead.org
Cc: Nicolas Pitre <nico@cam.org>, Martin Michlmayr <tbm@cyrius.com>
Subject: Re: [PATCH / RESENT #3] mtd: let include/linux/mtd/partitions.h stand on its own
Date: Fri, 10 Jul 2009 21:34:45 +0200 [thread overview]
Message-ID: <200907102134.46212.florian@openwrt.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0907101448360.3138@xanadu.home>
Hi Nicolas,
Le Friday 10 July 2009 20:51:33 Nicolas Pitre, vous avez écrit :
> When declaring static MTD partitions in board specific code, only
> including include/linux/mtd/partitions.h should suffice without
> gcc nagging us with:
>
> In file included from arch/arm/mach-kirkwood/sheevaplug-setup.c:14:
> include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared
> inside parameter list include/linux/mtd/partitions.h:50: warning: its scope
> is only this definition or declaration, which is probably not what you want
> include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared
> inside parameter list include/linux/mtd/partitions.h:61: warning: 'struct
> mtd_info' declared inside parameter list include/linux/mtd/partitions.h:67:
> warning: 'struct mtd_info' declared inside parameter list
>
> Signed-off-by: Nicolas Pitre <nico@marvell.com>
Thanks for doing this, Martin and I had the same problem on Cobalt Microservers (MIPS).
> ---
>
> Hello? Anybody home?
>
> diff --git a/include/linux/mtd/partitions.h
> b/include/linux/mtd/partitions.h index af6dcb9..b70313d 100644
> --- a/include/linux/mtd/partitions.h
> +++ b/include/linux/mtd/partitions.h
> @@ -47,6 +47,8 @@ struct mtd_partition {
> #define MTDPART_SIZ_FULL (0)
>
>
> +struct mtd_info;
> +
> int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *,
> int); int del_mtd_partitions(struct mtd_info *);
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
next prev parent reply other threads:[~2009-07-10 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 18:51 [PATCH / RESENT #3] mtd: let include/linux/mtd/partitions.h stand on its own Nicolas Pitre
2009-07-10 19:03 ` Mike Frysinger
2009-07-10 19:34 ` Florian Fainelli [this message]
2009-07-11 10:37 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907102134.46212.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@cam.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox