Re: [PATCH] [MTD] [CHIPS] cfi_cmdset_0001.c: put chip into read-array mode after unlocking

Mike Frysinger
2009-07-14T14:15:02Z

On Tue, Jul 14, 2009 at 09:56, Wolfram Sang wrote:
>> We should try and keep the flash in the default read-array mode when
>> possible so that we are much more likely to properly recover from
>> unexpected reboot events (such as watchdog expiring).  If we only unlock
>
> Hmm, the right thing to do would be fixing the watchdog to reset the flash
> correctly, no? As your patch makes non-working watchdogs less obvious, I fear
> that lockups will then happen when it's too late (= devices are deployed).

the CFI layers already go through steps to keep the memory in read
mode by default. the only way the watchdog could reconfigure the
flash is if it were setup to execute software instead of kick the
hardware, and that makes the system significantly less reliable.
-mike