Re: [PATCH] mtdblock: introduce mtdblks_lock

Artem Bityutskiy
2009-07-15T08:44:53Z

On Wed, 2009-07-15 at 10:36 +0200, Matthias Kaehlcke wrote:
> El Wed, Jul 15, 2009 at 10:41:54AM +0300 Artem Bityutskiy ha dit:
>
> > On Tue, 2009-07-14 at 22:04 +0200, Matthias Kaehlcke wrote:
> > > +static struct mutex mtdblks_lock;
> > > +
> > > /*
> > > * Cache stuff...
> > > *
> > > @@ -270,6 +272,8 @@ static int mtdblock_open(struct mtd_blktrans_dev *mbd)
> > >
> > > DEBUG(MTD_DEBUG_LEVEL1,"mtdblock_open\n");
> > >
> > > + mutex_lock(&mtdblks_lock);
> > > +
> > > if (mtdblks[dev]) {
> > > mtdblks[dev]->count++;
> > > return 0;
> >
> > Now about unlocking the mutex here?
>
> i missed this one ...
>
> thanks for your review. i'm going fix that and send out an updated
> version of the patch

Err, I've already amended your patch and put it to my l2-mtd-2.6.git:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git?a=commit;h=2a4d4fdb6393fdcbfea546b2474baf41d434302a

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)