Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c

Stefan Richter
2009-07-16T11:46:18Z

Subrata Modak wrote:
>> Well, I just thought this type of warnings and way of fixing is very
>> standard because I saw many similar fixes all over the place.
>
> Correct. There has been other warning fixes i have sent to LKML, where i
> have tweaked the code to fix the compilation, but, code tweaking may not
> be possible in this case.

Wrong goal. The goal of a patch should be to improve the code.

To remove false-positive warnings from compilation can only be a
secondary goal.

(See my other post.)

BTW, which compiler do you use? I quickly enabled ubifs here, first
without and then with its various sub-uptions, but didn't get a warning
here with "gcc (Gentoo 4.3.2-r3 p1.6, pie-10.1.5) 4.3.2".
--
Stefan Richter
-=====-==--= -=== =----