public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Linux MTD list <linux-mtd@lists.infradead.org>
Cc: Vladimir Barinov <vbarinov@embeddedalley.com>,
	Magnus Lilja <lilja.magnus@gmail.com>,
	Eric Benard <ebenard@eukrea.com>, Daniel Mack <daniel@caiaq.de>,
	Alberto Panizzo <maramaopercheseimorto@gmail.com>
Subject: MXC nand controller performance
Date: Thu, 20 Aug 2009 14:57:34 +0200	[thread overview]
Message-ID: <20090820125734.GI23444@pengutronix.de> (raw)

Hi,

Hi recently found out that on my i.MX27 board the mxc nand controller
performance nearly doubles when I disable interrupts. Can anybody
confirm this behaviour, possibly on other i.MXs?
I'm trying to figure out what to do. We could disable interrupts
completely in which case the driver would become simpler. Maybe using
polling mode has other impacts on other workloads, so maybe we want to
add a flag to platform_data instead of disabling interrupts completely.

You can use the following patch to disable interrupts. It is not meant
for inclusion in this form of course.

Sascha


>From ae3909b90667a13f7bbd6a042b6b65ea7c74ee48 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Thu, 20 Aug 2009 14:52:32 +0200
Subject: [PATCH] mxc_nand: disable interrupts

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/nand/mxc_nand.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 76beea4..bcc5929 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -175,6 +175,8 @@ static void wait_op_done(struct mxc_nand_host *host, int max_retries,
 {
 	uint32_t tmp;
 
+	useirq = 0;
+
 	if (useirq) {
 		if ((readw(host->regs + NFC_CONFIG2) & NFC_INT) == 0) {
 
-- 
1.6.3.3

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

             reply	other threads:[~2009-08-20 12:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-20 12:57 Sascha Hauer [this message]
2009-08-20 20:10 ` MXC nand controller performance Magnus Lilja
2009-08-21 12:22   ` Sascha Hauer
2009-08-23 19:39     ` Magnus Lilja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090820125734.GI23444@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=daniel@caiaq.de \
    --cc=ebenard@eukrea.com \
    --cc=lilja.magnus@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maramaopercheseimorto@gmail.com \
    --cc=vbarinov@embeddedalley.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox