Re: [U-Boot] NAND ECC Error with wrong SMC ording bug

Stefan Roese
2009-08-21T06:27:48Z

On Friday 21 August 2009 07:17:09 vimal singh wrote:
> > diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
> > index 89bf85a..497e175 100644
> > --- a/drivers/mtd/nand/ndfc.c
> > +++ b/drivers/mtd/nand/ndfc.c
> > @@ -101,9 +101,8 @@ static int ndfc_calculate_ecc(struct mtd_info *mtd,
> >
> > wmb();
> > ecc = in_be32(ndfc->ndfcbase + NDFC_ECC);
> > - /* The NDFC uses Smart Media (SMC) bytes order */
> > - ecc_code[0] = p[2];
> > - ecc_code[1] = p[1];
> > + ecc_code[0] = p[1];
> > + ecc_code[1] = p[2];
> > ecc_code[2] = p[3];
> >
> > return 0;
> >
> > Does anybody see a problem with my method of reproducing the bug? This
> > bug is deadly for our customers. I don't want to make the change unless
> > it is absolutely necessary..
>
> Just one question: did you enabled MTD_NAND_ECC_SMC in configs?

Yes, MTD_NAND_ECC_SMC is selected via Kconfig for this driver.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de