From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kyungmin Park <kmpark@infradead.org>
Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Samsung SoCs: OneNAND support
Date: Thu, 17 Sep 2009 21:00:54 +0100 [thread overview]
Message-ID: <20090917200054.GB12766@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090917081659.GA28591@july>
On Thu, Sep 17, 2009 at 05:16:59PM +0900, Kyungmin Park wrote:
> +#include <asm/io.h>
Please make sure that you use linux/io.h
> +static int s3c_onenand_probe(struct platform_device *pdev)
> +{
> + struct onenand_platform_data *pdata;
> + struct onenand_chip *this;
> + struct mtd_info *mtd;
> + struct resource *r;
> + int size, err;
> + unsigned long ahb_addr = 0, ahb_addr_size;
> +
> + if (!(cpu_is_s3c64xx() || cpu_is_s5pc1xx()))
> + return -ENODEV;
Isn't it normal to leave these kind of decisions to the declaration of
the devices, rather than encoding it into the driver?
next prev parent reply other threads:[~2009-09-17 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 8:16 [PATCH] Samsung SoCs: OneNAND support Kyungmin Park
2009-09-17 8:31 ` Artem Bityutskiy
2009-09-17 9:45 ` Kyungmin Park
2009-09-17 10:02 ` Kyungmin Park
2009-09-17 10:06 ` Artem Bityutskiy
2009-09-17 20:00 ` Russell King - ARM Linux [this message]
2009-09-18 12:11 ` Makhija, Neha (IE10)
-- strict thread matches above, loose matches on Subject: below --
2010-03-24 8:04 Kyungmin Park
2010-03-24 17:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090917200054.GB12766@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox