From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-pcmcia@lists.infradead.org, linux-mtd@lists.infradead.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 14/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)
Date: Mon, 26 Oct 2009 08:13:52 +0100 [thread overview]
Message-ID: <20091026071352.GA26980@isilmar.linta.de> (raw)
In-Reply-To: <1256539331.29885.360.camel@localhost>
Hey,
On Mon, Oct 26, 2009 at 08:42:11AM +0200, Artem Bityutskiy wrote:
> On Sat, 2009-10-24 at 21:43 +0200, Dominik Brodowski wrote:
> > Convert PCMCIA drivers to use the dynamic debug infrastructure, instead of
> > requiring manual settings of PCMCIA_DEBUG.
> >
> > Also, remove all usages of the CS_CHECK macro and replace them with proper
> > Linux style calling and return value checking. The extra error reporting may
> > be dropped, as the PCMCIA core already complains about any (non-driver-author)
> > errors.
> >
> > CC: linux-mtd@lists.infradead.org
> > CC: linux-usb@vger.kernel.org
> > Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
>
> Have you been able to test the driver after the clean-up?
No, I don't have all that much PCMCIA hardware -- and specifically none for
the drivers which were modified in this patch (parport, ixj-telephony,
sl811; pcmcia_mtd is marked broken anyway).
Best,
Dominik
next prev parent reply other threads:[~2009-10-26 7:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091024194219.GA19546@comet.dominikbrodowski.net>
2009-10-24 19:43 ` [PATCH 14/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (misc drivers) Dominik Brodowski
2009-10-26 6:42 ` Artem Bityutskiy
2009-10-26 7:13 ` Dominik Brodowski [this message]
2009-10-26 7:26 ` Artem Bityutskiy
2009-10-26 7:56 ` Dominik Brodowski
2009-10-26 8:05 ` Artem Bityutskiy
2009-10-26 10:19 ` Alan Cox
2009-10-26 10:18 ` Artem Bityutskiy
2009-11-03 8:37 ` Artem Bityutskiy
2009-11-07 11:19 ` pcmciamtd -- what's broken, who needs it? Dominik Brodowski
2009-11-07 11:29 ` Komuro
2009-11-07 11:33 ` Dominik Brodowski
2009-11-07 16:57 ` Kristoffer Ericson
2009-11-08 8:12 ` Dominik Brodowski
2009-11-07 22:33 ` Komuro
2009-11-04 10:20 ` PETEC 2MB SRAM Pep Talens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026071352.GA26980@isilmar.linta.de \
--to=linux@dominikbrodowski.net \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox