Re: [PATCH 14/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)

Artem Bityutskiy
2009-11-03T08:37:13Z

On Mon, 2009-10-26 at 12:18 +0200, Artem Bityutskiy wrote:
> On Mon, 2009-10-26 at 10:19 +0000, Alan Cox wrote:
> > > > No, I don't have all that much PCMCIA hardware -- and specifically none for
> > > > the drivers which were modified in this patch (parport, ixj-telephony,
> > > > sl811; pcmcia_mtd is marked broken anyway).
> > >
> > > This driver is old and ugly, and it is even possible that no one uses it
> > > anymore, so I guess getting clean-ups without testing is ok for it.
> > > However, in that case the clean-up patches should be reviewable, which I
> > > wouldn't say about your patch :-)
> > >
> > > Could you please split it on several smaller patches, each doing one
> > > thing only?
> >
> > pcmcia_mtd has been marked broken for how long - better to delete it ?
> > It's in the git history if anyone ever wants to resurrect it.
>
> I do not have objections. David?

I suggest to interpret the silence as "ok", go ahead and remove it.
Dominik, do you care enough to send a patch?

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)