public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: dwmw2@infradead.org
Cc: b24347@freescale.com, akpm@linux-foundation.org,
	leoli@freescale.com, linux-mtd@lists.infradead.org
Subject: [patch 4/4] mtd/nand: fix multi-chip suspend problem
Date: Tue, 17 Nov 2009 14:45:49 -0800	[thread overview]
Message-ID: <200911172245.nAHMjnss001994@imap1.linux-foundation.org> (raw)

From: Li Yang <leoli@freescale.com>

Symptom:
device_suspend(): mtd_cls_suspend+0x0/0x58 returns -11
PM: Device mtd14 failed to suspend: error -11
PM: Some devices failed to suspend

This patch enables other chips to be suspended if the active chip of
the controller has been suspended.

Signed-off-by: Jin Qing <b24347@freescale.com>
Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/mtd/nand/nand_base.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff -puN drivers/mtd/nand/nand_base.c~mtd-nand-fix-multi-chip-suspend-problem drivers/mtd/nand/nand_base.c
--- a/drivers/mtd/nand/nand_base.c~mtd-nand-fix-multi-chip-suspend-problem
+++ a/drivers/mtd/nand/nand_base.c
@@ -697,10 +697,16 @@ nand_get_device(struct nand_chip *chip, 
 		spin_unlock(lock);
 		return 0;
 	}
-	if (new_state == FL_PM_SUSPENDED) {
-		spin_unlock(lock);
-		return (chip->state == FL_PM_SUSPENDED) ? 0 : -EAGAIN;
-	}
+	if (new_state == FL_PM_SUSPENDED)
+		if (chip->controller->active->state == FL_PM_SUSPENDED) {
+			chip->state = FL_PM_SUSPENDED;
+			spin_unlock(lock);
+			return 0;
+		} else {
+			spin_unlock(lock);
+			return -EAGAIN;
+		}
+
 	set_current_state(TASK_UNINTERRUPTIBLE);
 	add_wait_queue(wq, &wait);
 	spin_unlock(lock);
_

             reply	other threads:[~2009-11-17 22:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 22:45 akpm [this message]
2009-11-23 15:19 ` [patch 4/4] mtd/nand: fix multi-chip suspend problem Artem Bityutskiy
2009-11-23 18:57   ` Ubiformat --erase-counter not always used Darwin Rambo
2009-11-24  6:57     ` Artem Bityutskiy
2009-11-26  9:41     ` Artem Bityutskiy
2009-11-23 20:24   ` [patch 4/4] mtd/nand: fix multi-chip suspend problem Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911172245.nAHMjnss001994@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=b24347@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=leoli@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox