From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: dwmw2@infradead.org
Cc: nico@fluxnic.net, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, u.kleine-koenig@pengutronix.de,
simon.kagstrom@netinsight.net, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MTD: Fix Orion NAND driver compilation with ARM OABI
Date: Sat, 20 Mar 2010 10:55:07 +0200 [thread overview]
Message-ID: <20100320085507.4038.96426.stgit@pauliusz> (raw)
We must tell GCC to use even register for variable passed
to ldrd instruction. Without this patch GCC 4.2.1 puts this
variable to r2/r3 on EABI and r3/r4 on OABI, so force it to
r2/r3. This does not change anything when EABI and OABI
compilation works OK.
Without this patch and with OABI I get:
CC drivers/mtd/nand/orion_nand.o
/tmp/ccMkwOCs.s: Assembler messages:
/tmp/ccMkwOCs.s:63: Error: first destination register must be even -- `ldrd r3,[ip]'
make[5]: *** [drivers/mtd/nand/orion_nand.o] Error 1
Signed-off-by: Paulius Zaleckas <paulius.zaleckas@gmail.com>
---
drivers/mtd/nand/orion_nand.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
index f59c074..cb5175e 100644
--- a/drivers/mtd/nand/orion_nand.c
+++ b/drivers/mtd/nand/orion_nand.c
@@ -60,7 +60,12 @@ static void orion_nand_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
}
buf64 = (uint64_t *)buf;
while (i < len/8) {
- uint64_t x;
+ /*
+ * force x variable to r2/r3 registers since ldrd instruction
+ * requires first register to be even.
+ */
+ register uint64_t x asm ("r2");
+
asm volatile ("ldrd\t%0, [%1]" : "=&r" (x) : "r" (io_base));
buf64[i++] = x;
}
next reply other threads:[~2010-03-20 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 8:55 Paulius Zaleckas [this message]
2010-03-20 9:41 ` [PATCH] MTD: Fix Orion NAND driver compilation with ARM OABI David Woodhouse
2010-03-20 11:20 ` Paulius Zaleckas
2010-03-20 11:58 ` David Woodhouse
2010-03-20 14:41 ` Nicolas Pitre
2010-03-20 15:06 ` Mikael Pettersson
2010-03-20 15:37 ` Nicolas Pitre
2010-03-21 17:16 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320085507.4038.96426.stgit@pauliusz \
--to=paulius.zaleckas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@fluxnic.net \
--cc=simon.kagstrom@netinsight.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).