From: Wolfram Sang <w.sang@pengutronix.de>
To: Guillaume LECERF <glecerf@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v2 3/7] mtd: cfi_probe: add support for SST 0x0701 vendorname
Date: Thu, 8 Apr 2010 11:05:53 +0200 [thread overview]
Message-ID: <20100408090553.GC21805@pengutronix.de> (raw)
In-Reply-To: <20100330133458.20107.48734.stgit@shiryu.yomgui.biz>
[-- Attachment #1: Type: text/plain, Size: 2433 bytes --]
On Tue, Mar 30, 2010 at 03:34:58PM +0200, Guillaume LECERF wrote:
> SST 39VF160x and 39VF320x chips use vendorname id 0x0701 and alternative
> unlock addresses. Add support for them in cfi_probe.c.
>
> Signed-off-by: Guillaume LECERF <glecerf@gmail.com>
> ---
> drivers/mtd/chips/cfi_probe.c | 9 +++++++++
> include/linux/mtd/cfi.h | 1 +
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
> index a28659d..f931e94 100644
> --- a/drivers/mtd/chips/cfi_probe.c
> +++ b/drivers/mtd/chips/cfi_probe.c
> @@ -214,6 +214,12 @@ static int __xipram cfi_chip_setup(struct map_info *map,
> * back into Read Mode, which is a nop in this case).
> */
> cfi_send_gen_cmd(0xf0, 0, base, map, cfi, cfi->device_type, NULL);
> +
> + if (cfi->cfiq->P_ID == P_ID_SST_OLD) {
> + addr_unlock1 = 0x5555;
> + addr_unlock2 = 0x2AAA;
> + }
Can't we set cfi->addr_unlock[12] here already? This way, we could later have
just one fixup function for all old SST flashes.
> +
> cfi_send_gen_cmd(0xaa, addr_unlock1, base, map, cfi, cfi->device_type, NULL);
> cfi_send_gen_cmd(0x55, addr_unlock2, base, map, cfi, cfi->device_type, NULL);
> cfi_send_gen_cmd(0x90, addr_unlock1, base, map, cfi, cfi->device_type, NULL);
> @@ -270,6 +276,9 @@ static char *vendorname(__u16 vendor)
> case P_ID_SST_PAGE:
> return "SST Page Write";
>
> + case P_ID_SST_OLD:
> + return "SST 39VF160x/39VF320x";
> +
> case P_ID_INTEL_PERFORMANCE:
> return "Intel Performance Code";
>
> diff --git a/include/linux/mtd/cfi.h b/include/linux/mtd/cfi.h
> index cee05b1..5716fc7 100644
> --- a/include/linux/mtd/cfi.h
> +++ b/include/linux/mtd/cfi.h
> @@ -253,6 +253,7 @@ struct cfi_bri_query {
> #define P_ID_MITSUBISHI_STD 0x0100
> #define P_ID_MITSUBISHI_EXT 0x0101
> #define P_ID_SST_PAGE 0x0102
> +#define P_ID_SST_OLD 0x0701
> #define P_ID_INTEL_PERFORMANCE 0x0200
> #define P_ID_INTEL_DATA 0x0210
> #define P_ID_RESERVED 0xffff
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-04-08 9:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 13:34 [PATCH v2 1/7] mtd: cfi_probe: enter Auto Select Mode after filling cfi->cfiq members Guillaume LECERF
2010-03-30 13:34 ` [PATCH v2 2/7] mtd: cfi_probe: make the addresses used to enter Auto Select Mode variable Guillaume LECERF
2010-03-30 13:34 ` [PATCH v2 3/7] mtd: cfi_probe: add support for SST 0x0701 vendorname Guillaume LECERF
2010-04-08 9:05 ` Wolfram Sang [this message]
2010-04-12 3:36 ` Wolfram Sang
2010-03-30 13:35 ` [PATCH v2 4/7] mtd: cfi_probe: use P_ID_* definitions instead of hardcoded values Guillaume LECERF
2010-03-30 13:35 ` [PATCH v2 5/7] mtd: cfi_cmdset_0002: do not fail on no extended query table as they are both optional Guillaume LECERF
2010-03-30 13:35 ` [PATCH v2 6/7] mtd: cfi_cmdset_0002: add CFI detection for SST 39VF{16, 32}xx chips Guillaume LECERF
2010-04-08 9:12 ` Wolfram Sang
2010-04-12 2:24 ` Wolfram Sang
2010-04-12 16:28 ` Fabio Giovagnini
2010-04-13 0:27 ` Wolfram Sang
2010-04-16 10:17 ` Guillaume LECERF
2010-04-18 23:29 ` Wolfram Sang
2010-04-20 9:44 ` Guillaume LECERF
2010-04-22 6:13 ` Wolfram Sang
2010-04-08 15:21 ` Wolfram Sang
2010-04-08 15:32 ` Guillaume LECERF
2010-04-09 8:55 ` Wolfram Sang
2010-03-30 13:35 ` [PATCH v2 7/7] mtd: cfi_cmdset_0002: add CFI detection for SST 39VF{32, 64}xxB chips Guillaume LECERF
2010-03-31 13:28 ` [PATCH v2 1/7] mtd: cfi_probe: enter Auto Select Mode after filling cfi->cfiq members Artem Bityutskiy
2010-04-02 11:46 ` Guillaume LECERF
2010-04-02 12:11 ` Artem Bityutskiy
2010-04-08 8:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408090553.GC21805@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=glecerf@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).