linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@logfs.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Paolo Minazzi <paolo.minazzi@gmail.com>,
	linux-mtd@lists.infradead.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register()
Date: Mon, 26 Apr 2010 18:31:27 +0200	[thread overview]
Message-ID: <20100426163126.GD4364@logfs.org> (raw)
In-Reply-To: <20100426163050.GC4364@logfs.org>

Otherwise we hit a BUG_ON in bdi_queue_work().

Signed-off-by: Joern Engel <joern@logfs.org>
---
 drivers/mtd/mtdcore.c |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index cb4858b..8dd3e46 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -299,7 +299,7 @@ static struct device_type mtd_devtype = {
 
 int add_mtd_device(struct mtd_info *mtd)
 {
-	int i;
+	int i, err;
 
 	if (!mtd->backing_dev_info) {
 		switch (mtd->type) {
@@ -322,6 +322,12 @@ int add_mtd_device(struct mtd_info *mtd)
 		if (!mtd_table[i]) {
 			struct mtd_notifier *not;
 
+			err = bdi_register(mtd->backing_dev_info, NULL, "mtd%d",
+					i);
+			if (err) {
+				/* We lose the errno information :( */
+				break;
+			}
 			mtd_table[i] = mtd;
 			mtd->index = i;
 			mtd->usecount = 0;
@@ -692,6 +698,15 @@ static int __init init_mtd(void)
 	int ret;
 	ret = class_register(&mtd_class);
 
+	ret = bdi_init(&mtd_bdi_unmappable);
+	if (ret)
+		return ret;
+	ret = bdi_init(&mtd_bdi_ro_mappable);
+	if (ret)
+		return ret;
+	ret = bdi_init(&mtd_bdi_rw_mappable);
+	if (ret)
+		return ret;
 	if (ret) {
 		pr_err("Error registering mtd class: %d\n", ret);
 		return ret;
-- 
1.6.2.1

  reply	other threads:[~2010-04-26 16:31 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-17 18:40 [PATCH] [MTD] Fix JFFS2 sync silent failure Jörn Engel
2010-04-19  7:38 ` Jens Axboe
2010-04-19 10:15   ` Jörn Engel
2010-04-19 10:20     ` Jens Axboe
2010-04-19 11:39       ` Jörn Engel
2010-04-22  5:54       ` Jörn Engel
2010-04-22  6:26         ` Jörn Engel
2010-04-22 14:25           ` Linus Torvalds
2010-04-22 14:33             ` Linus Torvalds
2010-04-22 16:27               ` Jens Axboe
2010-04-22 20:33                 ` [Patch] Catch filesystems lacking s_bdi Jörn Engel
2010-04-23 10:05                   ` Jens Axboe
2010-04-23 20:55                     ` Jörn Engel
2010-04-26  9:48                       ` Jens Axboe
2010-04-26 14:32                         ` Jörn Engel
2010-04-26 14:38                           ` Jens Axboe
2010-04-26 14:45                             ` Jens Axboe
2010-04-26 16:30                               ` [PATCH 1/2] [MTD] Move mtd_bdi_*mappable to mtdcore.c Jörn Engel
2010-04-26 16:31                                 ` Jörn Engel [this message]
2010-04-26 17:02                                   ` [PATCH 2/2] [MTD] Call bdi_init() and bdi_register() Jens Axboe
2010-04-26 17:12                                     ` Jörn Engel
2010-04-27  7:52                                       ` Jens Axboe
2010-04-27  8:11                                         ` Paolo Minazzi
2010-04-27  8:16                                           ` Jens Axboe
2010-04-27 11:29                                         ` Jörn Engel
2010-04-27 11:33                                           ` Jens Axboe
2010-04-27  9:01                                   ` Paolo Minazzi
2010-04-27  9:16                                     ` Jens Axboe
2010-04-27  9:26                                       ` Paolo Minazzi
2010-04-27  9:29                                         ` Jens Axboe
2010-04-27  9:36                                           ` Paolo Minazzi
2010-04-27 11:17                                     ` Jörn Engel
2010-04-27 11:31                                       ` Paolo Minazzi
2010-04-27 11:40                                         ` Jörn Engel
2010-04-27 11:48                                           ` [PATCH] [LogFS] Return -EINVAL if filesystem image doesn't match Jörn Engel
2010-04-27 12:53                                             ` Paolo Minazzi
2010-04-27 11:54                                           ` [PATCH 2/2] [MTD] Call bdi_init() and bdi_register() Paolo Minazzi
2010-04-27 12:05                                             ` Jörn Engel
2010-04-26 17:01                                 ` [PATCH 1/2] [MTD] Move mtd_bdi_*mappable to mtdcore.c Jens Axboe
2010-04-26 17:08                                   ` Jörn Engel
2010-04-26 17:10                                     ` Jens Axboe
2010-04-22  9:03         ` [PATCH] [MTD] Fix JFFS2 sync silent failure Jens Axboe
2010-04-22 10:39           ` Jens Axboe
2010-04-22 10:58             ` David Woodhouse
2010-04-22 11:05               ` Jens Axboe
2010-04-22 11:55             ` Jörn Engel
2010-04-22 12:08               ` Jens Axboe
2010-04-22 12:17                 ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100426163126.GD4364@logfs.org \
    --to=joern@logfs.org \
    --cc=dwmw2@infradead.org \
    --cc=hch@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=paolo.minazzi@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).