From: Robert Schwebel <r.schwebel@pengutronix.de>
To: David Woodhouse <David.Woodhouse@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-mtd@lists.infradead.org,
Ivo Clarysse <ivo.clarysse@gmail.com>
Subject: Re: mxc-nand duplicate case value in -next
Date: Thu, 29 Apr 2010 10:09:54 +0200 [thread overview]
Message-ID: <20100429080954.GI6204@pengutronix.de> (raw)
In-Reply-To: <20100427075310.GM18567@pengutronix.de>
David,
On Tue, Apr 27, 2010 at 09:53:10AM +0200, Robert Schwebel wrote:
> On Fri, Apr 23, 2010 at 09:36:25AM +0200, Sascha Hauer wrote:
> > Currently we have a duplicate case value in the mxc-nand driver in
> > -next. This is because of to different patches adding reset command
> > support to the driver, one from Eric (coming via the mtd master tree)
> > and one from Ivo (coming from the mxc master tree). As I see it we
> > should take Ivos patch as it adds i.MX21 support along the way, so
> > David, can you please drop Erics patch?
>
> linux-next does still crash with
>
> drivers/mtd/nand/mxc_nand.c: In function 'mxc_nand_command':
> drivers/mtd/nand/mxc_nand.c:689: error: duplicate case value
> drivers/mtd/nand/mxc_nand.c:606: error: previously used here
> drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_resume':
> drivers/mtd/nand/mxc_nand.c:921: warning: unused variable 'host'
> make[3]: *** [drivers/mtd/nand/mxc_nand.o] Error 1
>
> David, would dropping Eric's patch (like suggested by Sascha) be an
> acceptable solution?
ping
rsc
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-04-29 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 7:36 mxc-nand duplicate case value in -next Sascha Hauer
2010-04-27 7:53 ` Robert Schwebel
2010-04-29 8:09 ` Robert Schwebel [this message]
2010-05-17 20:15 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100429080954.GI6204@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=David.Woodhouse@intel.com \
--cc=ivo.clarysse@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).