* [PATCH] mtd: cfi_probe: print manufacturer and id of probed chip
@ 2010-06-14 10:33 Guillaume LECERF
2010-06-29 6:45 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Guillaume LECERF @ 2010-06-14 10:33 UTC (permalink / raw)
To: linux-mtd; +Cc: David Woodhouse
Signed-off-by: Guillaume LECERF <glecerf@gmail.com>
---
drivers/mtd/chips/cfi_probe.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
index b2acd32..5f5ba3e 100644
--- a/drivers/mtd/chips/cfi_probe.c
+++ b/drivers/mtd/chips/cfi_probe.c
@@ -235,9 +235,9 @@ static int __xipram cfi_chip_setup(struct map_info *map,
cfi_qry_mode_off(base, map, cfi);
xip_allowed(base, map);
- printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank\n",
+ printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank. mfr=0x%08x id=0x%08x\n",
map->name, cfi->interleave, cfi->device_type*8, base,
- map->bankwidth*8);
+ map->bankwidth*8, cfi->mfr, cfi->id);
return 1;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: cfi_probe: print manufacturer and id of probed chip
2010-06-14 10:33 [PATCH] mtd: cfi_probe: print manufacturer and id of probed chip Guillaume LECERF
@ 2010-06-29 6:45 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-06-29 6:45 UTC (permalink / raw)
To: Guillaume LECERF; +Cc: David Woodhouse, linux-mtd
On Mon, 2010-06-14 at 12:33 +0200, Guillaume LECERF wrote:
> Signed-off-by: Guillaume LECERF <glecerf@gmail.com>
> ---
> drivers/mtd/chips/cfi_probe.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
> index b2acd32..5f5ba3e 100644
> --- a/drivers/mtd/chips/cfi_probe.c
> +++ b/drivers/mtd/chips/cfi_probe.c
> @@ -235,9 +235,9 @@ static int __xipram cfi_chip_setup(struct map_info *map,
> cfi_qry_mode_off(base, map, cfi);
> xip_allowed(base, map);
>
> - printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank\n",
> + printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank. mfr=0x%08x id=0x%08x\n",
> map->name, cfi->interleave, cfi->device_type*8, base,
> - map->bankwidth*8);
> + map->bankwidth*8, cfi->mfr, cfi->id);
This is not a debugging print, so I think you should do it in a more
user-friendly way. E.g., "manufect. ID %#08x, chip id %#08x".
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mtd: cfi_probe: print manufacturer and id of probed chip
@ 2010-06-29 8:32 Guillaume LECERF
2010-07-13 9:54 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Guillaume LECERF @ 2010-06-29 8:32 UTC (permalink / raw)
To: linux-mtd; +Cc: David Woodhouse, Artem Bityutskiy
2010/6/29 Artem Bityutskiy <dedekind1@gmail.com>:
> This is not a debugging print, so I think you should do it in a more
> user-friendly way. E.g., "manufect. ID %#08x, chip id %#08x".
OK, here it is again.
Signed-off-by: Guillaume LECERF <glecerf@gmail.com>
---
drivers/mtd/chips/cfi_probe.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
index b2acd32..8f5b96a 100644
--- a/drivers/mtd/chips/cfi_probe.c
+++ b/drivers/mtd/chips/cfi_probe.c
@@ -235,9 +235,9 @@ static int __xipram cfi_chip_setup(struct map_info *map,
cfi_qry_mode_off(base, map, cfi);
xip_allowed(base, map);
- printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank\n",
+ printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank. Manufacturer ID %#08x Chip ID %#08x\n",
map->name, cfi->interleave, cfi->device_type*8, base,
- map->bankwidth*8);
+ map->bankwidth*8, cfi->mfr, cfi->id);
return 1;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: cfi_probe: print manufacturer and id of probed chip
2010-06-29 8:32 Guillaume LECERF
@ 2010-07-13 9:54 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-07-13 9:54 UTC (permalink / raw)
To: Guillaume LECERF; +Cc: David Woodhouse, linux-mtd
On Tue, 2010-06-29 at 10:32 +0200, Guillaume LECERF wrote:
> 2010/6/29 Artem Bityutskiy <dedekind1@gmail.com>:
> > This is not a debugging print, so I think you should do it in a more
> > user-friendly way. E.g., "manufect. ID %#08x, chip id %#08x".
>
> OK, here it is again.
>
> Signed-off-by: Guillaume LECERF <glecerf@gmail.com>
Pushed to l2-mtd-2.6.git / master
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-13 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-14 10:33 [PATCH] mtd: cfi_probe: print manufacturer and id of probed chip Guillaume LECERF
2010-06-29 6:45 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2010-06-29 8:32 Guillaume LECERF
2010-07-13 9:54 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).