From: Anatolij Gustschin <agust@denx.de>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Detlev Zundel <dzu@denx.de>
Subject: Re: [PATCH v3] mtdchar: fix mmap() for MTD RAM/ROM char devices
Date: Mon, 14 Jun 2010 11:22:13 +0200 [thread overview]
Message-ID: <20100614112213.695ac5d2@wker> (raw)
In-Reply-To: <AANLkTikutI1bWUpG4FDWwwKOGSEfik-ycZZLs37AjDtK@mail.gmail.com>
On Sat, 12 Jun 2010 21:31:11 -0400
Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Sat, Jun 12, 2010 at 15:35, Anatolij Gustschin wrote:
> > For no-mmu systems mmap() on RAM/ROM devices already works
> > but for systems with mmu it probably was not tested and
> > currently doesn't work.
>
> nope, never did
Do you mean it never worked on mmu systems?
>
> > + if (vma->vm_pgoff > (~0UL >> PAGE_SHIFT))
> > + return -EINVAL;
>
> i'm pretty sure this is inappropriate and doesnt belong here
Then I'll drop this in the next patch.
Thanks,
Anatolij
next prev parent reply other threads:[~2010-06-14 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 19:35 [PATCH v3] mtdchar: fix mmap() for MTD RAM/ROM char devices Anatolij Gustschin
2010-06-13 1:31 ` Mike Frysinger
2010-06-14 9:22 ` Anatolij Gustschin [this message]
2010-06-14 18:21 ` Mike Frysinger
2010-06-15 7:30 ` [PATCH v4] " Anatolij Gustschin
2010-06-15 16:55 ` Mike Frysinger
2010-07-07 14:02 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614112213.695ac5d2@wker \
--to=agust@denx.de \
--cc=Artem.Bityutskiy@nokia.com \
--cc=dwmw2@infradead.org \
--cc=dzu@denx.de \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).