[PATCH] fix parallel build between ubi-utils and mkfs.ubifs

[PATCH] fix parallel build between ubi-utils and mkfs.ubifs

[Mike Frysinger]

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index b558705..8457654 100644
--- a/Makefile
+++ b/Makefile
@@ -9,6 +9,9 @@ endif
 
 SUBDIRS = lib ubi-utils mkfs.ubifs
 
+# mkfs.ubifs needs -lubi which is in ubi-utils/
+subdirs_mkfs.ubifs_all: subdirs_ubi-utils_all
+
 TARGETS = ftl_format flash_erase flash_eraseall nanddump doc_loadbios \
 	ftl_check mkfs.jffs2 flash_lock flash_unlock flash_info \
 	flash_otp_info flash_otp_dump mtd_debug flashcp nandwrite nandtest \
-- 
1.7.1.1

Re: [PATCH] fix parallel build between ubi-utils and mkfs.ubifs

[Florian Fainelli]

Hi,

On Tuesday 20 July 2010 05:06:41 Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index b558705..8457654 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -9,6 +9,9 @@ endif
> 
>  SUBDIRS = lib ubi-utils mkfs.ubifs
> 
> +# mkfs.ubifs needs -lubi which is in ubi-utils/
> +subdirs_mkfs.ubifs_all: subdirs_ubi-utils_all
> +

Do not you want this to be moved after include common.mk instead?
I had a build error with your patch, the version below works for me.
--

--- a/Makefile  2010-01-15 18:12:24.000000000 +0100
+++ b/Makefile  2010-07-20 15:23:02.000000000 +0200
@@ -22,6 +22,9 @@
 
 include common.mk
 
+# mkfs.ubifs needs -lubi which is in ubi-utils/
+subdirs_mkfs.ubifs_all: subdirs_ubi-utils_all
+
 clean::
        -rm -f $(SYMLINKS)
 ifneq ($(BUILDDIR)/.git,)

--
Florian

[PATCH v2] fix parallel build between ubi-utils and mkfs.ubifs

[Mike Frysinger]

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
fix target order pointed out by Florian Fainelli

 Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index b558705..d315f39 100644
--- a/Makefile
+++ b/Makefile
@@ -25,6 +25,9 @@ LDDEPS = $(BUILDDIR)/lib/libmtd.a
 
 include common.mk
 
+# mkfs.ubifs needs -lubi which is in ubi-utils/
+subdirs_mkfs.ubifs_all: subdirs_ubi-utils_all
+
 clean::
 	-rm -f $(SYMLINKS)
 ifneq ($(BUILDDIR)/.git,)
-- 
1.7.1.1

Re: [PATCH v2] fix parallel build between ubi-utils and mkfs.ubifs

[Artem Bityutskiy]

On Tue, 2010-07-20 at 17:27 -0400, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> fix target order pointed out by Florian Fainelli

Pushed, thank you!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)