Re: [RFC] nand/davinci: Fix comment to match the code

[Wolfram Sang <w.sang@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]

Sudhakar,

> > commit 1c3275b656045aff9a75bb2c9f3251af1043ebb3
> > Author: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> > Date:   Tue Jul 20 15:24:01 2010 -0700
> > 
> >     mtd: nand: davinci: correct 4-bit error correction
> >     
> >     On TI's DA830/OMAP-L137, DA850/OMAP-L138 and DM365, after setting the
> >     4BITECC_ADD_CALC_START bit in the NAND Flash control register to 1 and
> >     before waiting for the NAND Flash status register to be equal to 1, 2 or
> >     3, we have to wait till the ECC HW goes to correction state.  Without this
> >     wait, ECC correction calculations will not be proper.
> >     
> >     This has been tested on DA830/OMAP-L137, DA850/OMAP-L138, DM355 and DM365
> >     EVMs.
> >     
> >     Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> >     Acked-by: Sneha Narnakaje <nsnehaprabha@ti.com>
> >     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> >     Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> >     Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
> > 
> > then it is already in upstream in Linus' tree. I do not have anything else from you.
> > 
> 
> Yes, this was the patch I was talking about. But this patch seems little
> different than the one I submitted to linux-mtd list at
> http://patchwork.ozlabs.org/patch/59180/. But I can submit another patch
> which corrects it. 
> 
> Wolfram Sang,
> Do you agree that in the above link which shows the patch I have submitted,
> the comment matches the code?

Yes. Also, where and how 'timeo' is handled is much better in this patch. If
you create an update patch to make the code look like in the patchwork-link,
you can instantly add my:

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]