* [PATCH 2/3] MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
@ 2010-08-27 2:55 Kyungmin Park
2010-08-30 12:49 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Kyungmin Park @ 2010-08-27 2:55 UTC (permalink / raw)
To: linux-mtd; +Cc: Artem.Bityutskiy, dwmw2
From: Kyungmin Park <kyungmin.park@samsung.com>
When DMA error occurs. it's loop hang since it can't exit the loop.
and it's the right DMA handling code as Spec.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mtd/onenand/samsung.c | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
index 05329ba..69e48d0 100644
--- a/drivers/mtd/onenand/samsung.c
+++ b/drivers/mtd/onenand/samsung.c
@@ -554,14 +554,13 @@ static int s5pc110_dma_ops(void *dst, void *src, size_t count, int direction)
do {
status = readl(base + S5PC110_DMA_TRANS_STATUS);
+ if (status & S5PC110_DMA_TRANS_STATUS_TE) {
+ writel(S5PC110_DMA_TRANS_CMD_TEC,
+ base + S5PC110_DMA_TRANS_CMD);
+ return -EIO;
+ }
} while (!(status & S5PC110_DMA_TRANS_STATUS_TD));
- if (status & S5PC110_DMA_TRANS_STATUS_TE) {
- writel(S5PC110_DMA_TRANS_CMD_TEC, base + S5PC110_DMA_TRANS_CMD);
- writel(S5PC110_DMA_TRANS_CMD_TDC, base + S5PC110_DMA_TRANS_CMD);
- return -EIO;
- }
-
writel(S5PC110_DMA_TRANS_CMD_TDC, base + S5PC110_DMA_TRANS_CMD);
return 0;
--
1.5.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
2010-08-27 2:55 [PATCH 2/3] MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs Kyungmin Park
@ 2010-08-30 12:49 ` Artem Bityutskiy
2010-08-30 13:41 ` Kyungmin Park
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2010-08-30 12:49 UTC (permalink / raw)
To: Kyungmin Park; +Cc: Artem.Bityutskiy, linux-mtd, dwmw2
On Fri, 2010-08-27 at 11:55 +0900, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> When DMA error occurs. it's loop hang since it can't exit the loop.
> and it's the right DMA handling code as Spec.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mtd/onenand/samsung.c | 11 +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
> index 05329ba..69e48d0 100644
> --- a/drivers/mtd/onenand/samsung.c
> +++ b/drivers/mtd/onenand/samsung.c
> @@ -554,14 +554,13 @@ static int s5pc110_dma_ops(void *dst, void *src, size_t count, int direction)
>
> do {
> status = readl(base + S5PC110_DMA_TRANS_STATUS);
> + if (status & S5PC110_DMA_TRANS_STATUS_TE) {
> + writel(S5PC110_DMA_TRANS_CMD_TEC,
> + base + S5PC110_DMA_TRANS_CMD);
> + return -EIO;
> + }
> } while (!(status & S5PC110_DMA_TRANS_STATUS_TD));
>
> - if (status & S5PC110_DMA_TRANS_STATUS_TE) {
> - writel(S5PC110_DMA_TRANS_CMD_TEC, base + S5PC110_DMA_TRANS_CMD);
> - writel(S5PC110_DMA_TRANS_CMD_TDC, base + S5PC110_DMA_TRANS_CMD);
> - return -EIO;
> - }
> -
> writel(S5PC110_DMA_TRANS_CMD_TDC, base + S5PC110_DMA_TRANS_CMD);
You shoule also add timeout to the loop. Forever loops are bad. Please,
while you are on it, fix the forever loop by doing something like this:
http://patchwork.ozlabs.org/patch/59180/
I mean, add timeout please.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
2010-08-30 12:49 ` Artem Bityutskiy
@ 2010-08-30 13:41 ` Kyungmin Park
0 siblings, 0 replies; 3+ messages in thread
From: Kyungmin Park @ 2010-08-30 13:41 UTC (permalink / raw)
To: dedekind1; +Cc: Artem.Bityutskiy, linux-mtd, dwmw2
On Mon, Aug 30, 2010 at 9:49 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Fri, 2010-08-27 at 11:55 +0900, Kyungmin Park wrote:
>> From: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> When DMA error occurs. it's loop hang since it can't exit the loop.
>> and it's the right DMA handling code as Spec.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/mtd/onenand/samsung.c | 11 +++++------
>> 1 files changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
>> index 05329ba..69e48d0 100644
>> --- a/drivers/mtd/onenand/samsung.c
>> +++ b/drivers/mtd/onenand/samsung.c
>> @@ -554,14 +554,13 @@ static int s5pc110_dma_ops(void *dst, void *src, size_t count, int direction)
>>
>> do {
>> status = readl(base + S5PC110_DMA_TRANS_STATUS);
>> + if (status & S5PC110_DMA_TRANS_STATUS_TE) {
>> + writel(S5PC110_DMA_TRANS_CMD_TEC,
>> + base + S5PC110_DMA_TRANS_CMD);
>> + return -EIO;
>> + }
>> } while (!(status & S5PC110_DMA_TRANS_STATUS_TD));
>>
>> - if (status & S5PC110_DMA_TRANS_STATUS_TE) {
>> - writel(S5PC110_DMA_TRANS_CMD_TEC, base + S5PC110_DMA_TRANS_CMD);
>> - writel(S5PC110_DMA_TRANS_CMD_TDC, base + S5PC110_DMA_TRANS_CMD);
>> - return -EIO;
>> - }
>> -
>> writel(S5PC110_DMA_TRANS_CMD_TDC, base + S5PC110_DMA_TRANS_CMD);
>
> You shoule also add timeout to the loop. Forever loops are bad. Please,
> while you are on it, fix the forever loop by doing something like this:
> http://patchwork.ozlabs.org/patch/59180/
> I mean, add timeout please.
No problem, I will update this patch tomorrow.
Thank you,
Kyungmin Park
>
> --
> Best Regards,
> Artem Bityutskiy (Битюцкий Артём)
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-30 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-27 2:55 [PATCH 2/3] MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs Kyungmin Park
2010-08-30 12:49 ` Artem Bityutskiy
2010-08-30 13:41 ` Kyungmin Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).