linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4 v2] NAND: add support for reading ONFI parameters
@ 2010-08-18 12:01 Florian Fainelli
  2010-08-30  8:23 ` Artem Bityutskiy
  0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2010-08-18 12:01 UTC (permalink / raw)
  To: linux-mtd
  Cc: Maxime Bizon, David Woodhouse, Matthieu CASTET, Brian Norris,
	Artem Bityutskiy

Hi,

This is the second version of the patch series adding support for ONFI 
parameters to NAND device.

Florian Fainelli (4):
  NAND: add NAND_CMD_PARAM (0xec) definition
  NAND: denali should also handle NAND_CMD_PARAM
  lib: add crc16_le helper
  NAND: add support for reading ONFI parameters from NAND device

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/4 v2] NAND: add support for reading ONFI parameters
  2010-08-18 12:01 [PATCH 0/4 v2] NAND: add support for reading ONFI parameters Florian Fainelli
@ 2010-08-30  8:23 ` Artem Bityutskiy
  2010-08-30  8:36   ` Artem Bityutskiy
  0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2010-08-30  8:23 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: David Woodhouse, linux-mtd, Matthieu CASTET, Brian Norris,
	Maxime Bizon

On Wed, 2010-08-18 at 14:01 +0200, Florian Fainelli wrote:
> Hi,
> 
> This is the second version of the patch series adding support for ONFI 
> parameters to NAND device.
> 
> Florian Fainelli (4):
>   NAND: add NAND_CMD_PARAM (0xec) definition
>   NAND: denali should also handle NAND_CMD_PARAM
>   lib: add crc16_le helper
>   NAND: add support for reading ONFI parameters from NAND device

Hi,

since I did not review your patches, I am picking them and pushing to
l2-mtd-2.6.git / dunno branch. I'll try to encourage dwmw2 to look at
them and take them to the mtd tree, so they would have some exposure in
the -next tree.

But some "Tested-by" / "Reviewed-by" tags would certainly be useful,
anyone?

Also, the last patch did not apply cleanly, could you take a look
whether the patch utility got it right?

Applying: mtd: nand: add support for reading ONFI parameters from NAND device
error: patch failed: drivers/mtd/nand/nand_base.c:2943
error: drivers/mtd/nand/nand_base.c: patch does not apply
Patch failed at 0001 mtd: nand: add support for reading ONFI parameters from NAND device
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
[dedekind@brekeke l2-mtd-2.6]$ patch -p1 < .git/rebase-apply/patch 
patching file drivers/mtd/nand/Kconfig
patching file drivers/mtd/nand/nand_base.c
Hunk #6 succeeded at 2991 (offset 1 line).
Hunk #7 succeeded at 3020 (offset 1 line).
Hunk #8 succeeded at 3045 with fuzz 2 (offset -3 lines).
Hunk #9 succeeded at 3084 (offset -3 lines).
Hunk #10 succeeded at 3107 (offset -3 lines).
Hunk #11 succeeded at 3117 (offset -3 lines).
Hunk #12 succeeded at 3135 (offset -3 lines).
patching file include/linux/mtd/nand.h

My tree is here:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git

Thanks. 
-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/4 v2] NAND: add support for reading ONFI parameters
  2010-08-30  8:23 ` Artem Bityutskiy
@ 2010-08-30  8:36   ` Artem Bityutskiy
  2010-08-30  8:52     ` Florian Fainelli
  0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2010-08-30  8:36 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: David Woodhouse, linux-mtd, Matthieu CASTET, Brian Norris,
	Maxime Bizon

On Mon, 2010-08-30 at 11:23 +0300, Artem Bityutskiy wrote:
> On Wed, 2010-08-18 at 14:01 +0200, Florian Fainelli wrote:
> > Hi,
> > 
> > This is the second version of the patch series adding support for ONFI 
> > parameters to NAND device.
> > 
> > Florian Fainelli (4):
> >   NAND: add NAND_CMD_PARAM (0xec) definition
> >   NAND: denali should also handle NAND_CMD_PARAM
> >   lib: add crc16_le helper
> >   NAND: add support for reading ONFI parameters from NAND device
> 
> Hi,
> 
> since I did not review your patches, I am picking them and pushing to
> l2-mtd-2.6.git / dunno branch. I'll try to encourage dwmw2 to look at
> them and take them to the mtd tree, so they would have some exposure in
> the -next tree.
> 
> But some "Tested-by" / "Reviewed-by" tags would certainly be useful,
> anyone?

OK, I've noticed the further discussion. Your patches are not threaded
with this e-mail, and this confused me.

So I'm removing your patches from my tree and waiting for newer
patch-set.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/4 v2] NAND: add support for reading ONFI parameters
  2010-08-30  8:36   ` Artem Bityutskiy
@ 2010-08-30  8:52     ` Florian Fainelli
  0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2010-08-30  8:52 UTC (permalink / raw)
  To: dedekind1
  Cc: David Woodhouse, linux-mtd, Matthieu CASTET, Brian Norris,
	Maxime Bizon

Hello Artem,

On Monday 30 August 2010 10:36:16 Artem Bityutskiy wrote:
> On Mon, 2010-08-30 at 11:23 +0300, Artem Bityutskiy wrote:
> > On Wed, 2010-08-18 at 14:01 +0200, Florian Fainelli wrote:
> > > Hi,
> > > 
> > > This is the second version of the patch series adding support for ONFI
> > > parameters to NAND device.
> > > 
> > > Florian Fainelli (4):
> > >   NAND: add NAND_CMD_PARAM (0xec) definition
> > >   NAND: denali should also handle NAND_CMD_PARAM
> > >   lib: add crc16_le helper
> > >   NAND: add support for reading ONFI parameters from NAND device
> > 
> > Hi,
> > 
> > since I did not review your patches, I am picking them and pushing to
> > l2-mtd-2.6.git / dunno branch. I'll try to encourage dwmw2 to look at
> > them and take them to the mtd tree, so they would have some exposure in
> > the -next tree.
> > 
> > But some "Tested-by" / "Reviewed-by" tags would certainly be useful,
> > anyone?
> 
> OK, I've noticed the further discussion. Your patches are not threaded
> with this e-mail, and this confused me.
> 
> So I'm removing your patches from my tree and waiting for newer
> patch-set.

Yes, I will resubmit new patches later today. Thanks!
--
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-08-30  8:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18 12:01 [PATCH 0/4 v2] NAND: add support for reading ONFI parameters Florian Fainelli
2010-08-30  8:23 ` Artem Bityutskiy
2010-08-30  8:36   ` Artem Bityutskiy
2010-08-30  8:52     ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).