From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OrUgb-0000qS-GS for linux-mtd@lists.infradead.org; Fri, 03 Sep 2010 11:44:02 +0000 Received: by eye22 with SMTP id 22so1092703eye.36 for ; Fri, 03 Sep 2010 04:44:00 -0700 (PDT) Date: Fri, 3 Sep 2010 15:43:57 +0400 From: Anton Vorontsov To: Roy Zang Subject: Re: [PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect nand flash partitions Message-ID: <20100903114357.GC11847@oksana.dev.rtsoft.ru> References: <1281063096-26598-1-git-send-email-tie-fei.zang@freescale.com> <1281063096-26598-2-git-send-email-tie-fei.zang@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1281063096-26598-2-git-send-email-tie-fei.zang@freescale.com> Cc: B25806@freescale.com, linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Scott Wood , akpm@linux-foundation.org, B11780@freescale.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Aug 06, 2010 at 10:51:35AM +0800, Roy Zang wrote: [...] > > +static struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl; > + Are you sure that you want it as a global var? A bit scary change. Oh, you probably don't need it, as you can get it from fsl_lbc_ctrl_dev->nand? I wonder if Scott saw these patches? Cc'ed. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2