From: Wolfram Sang <w.sang@pengutronix.de>
To: Jon Povey <Jon.Povey@racelogic.co.uk>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH 2/2] nanddump: add --nobad to read bad blocks
Date: Mon, 13 Sep 2010 08:22:09 +0200 [thread overview]
Message-ID: <20100913062209.GA7382@pengutronix.de> (raw)
In-Reply-To: <70E876B0EA86DD4BAF101844BC814DFE0903E3E3DC@Cloud.RL.local>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Mon, Sep 13, 2010 at 06:50:04AM +0100, Jon Povey wrote:
> Mike Frysinger wrote:
> > Sometimes dumping bad blocks is useful, like when the data isn't actually
> > bad but the OOB layout isn't what the kernel is expecting or is otherwise
> > screwed up. The --nobad option allows just that.
>
> > +"-N --nobad Read without bad block skipping\n"
>
> This doesn't seem like a good name for the option to me. A useful option but
> an unintuitive name, "nobad" sounds like it is going to omit bad blocks,
> where actually it is going to include them.
>
> "noskipbad" or "includebad" would seem to be better.
I agree. Is that still fixable despite being pushed already?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-09-13 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 3:50 [PATCH 1/2] nanddump: drop unused --ignoreerrors option Mike Frysinger
2010-09-12 3:50 ` [PATCH 2/2] nanddump: add --nobad to read bad blocks Mike Frysinger
2010-09-12 8:11 ` Artem Bityutskiy
2010-09-13 5:50 ` Jon Povey
2010-09-13 6:22 ` Wolfram Sang [this message]
2010-09-13 6:24 ` Artem Bityutskiy
2010-09-13 7:15 ` [PATCH] nanddump: Rename --nobad to --noskipbad Wolfram Sang
2010-09-17 6:20 ` Artem Bityutskiy
2010-09-17 7:54 ` Wolfram Sang
2010-09-17 8:24 ` Artem Bityutskiy
2010-09-18 17:16 ` Artem Bityutskiy
2010-09-12 8:09 ` [PATCH 1/2] nanddump: drop unused --ignoreerrors option Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100913062209.GA7382@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=Jon.Povey@racelogic.co.uk \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).