From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1P0r5s-0004VR-U2 for linux-mtd@lists.infradead.org; Wed, 29 Sep 2010 07:28:50 +0000 Date: Wed, 29 Sep 2010 09:28:43 +0200 From: Sascha Hauer To: David Woodhouse Subject: Re: [PATCH] mtd: mxc_nand: do not depend on disabling the irq in the interrupt handler Message-ID: <20100929072843.GC23406@pengutronix.de> References: <1285054802-21388-1-git-send-email-s.hauer@pengutronix.de> <1285054802-21388-2-git-send-email-s.hauer@pengutronix.de> <1285240612.29268.76.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1285240612.29268.76.camel@localhost> Cc: linux-mtd@lists.infradead.org, Artem Bityutskiy List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , David, On Thu, Sep 23, 2010 at 02:16:52PM +0300, Artem Bityutskiy wrote: > On Tue, 2010-09-21 at 09:40 +0200, Sascha Hauer wrote: > > This patch reverts the driver to enabling/disabling the NFC interrupt > > mask rather than enabling/disabling the system interrupt. This cleans > > up the driver so that it doesn't rely on interrupts being disabled > > within the interrupt handler. > > For i.MX21 we keep the current behaviour, that is calling > > enable_irq/disable_irq_nosync to enable/disable interrupts. > > This patch is based on earlier work by John Ogness. > > > > Signed-off-by: Sascha Hauer > > Acked-by: John Ogness > > Tested-by: John Ogness > > I've created l2-mtd-2.6.git/for-2.6.36 branch, pushed your patch there, > pinged dwmw2 for you. I do not give you any guarantees this will reach > 2.6.36, you have to ping dwmw2. Any chance to get this in? The mxc-nand driver is nonfunctional at the moment and 2.6.36 is getting closer. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |