* mtd: fix build error in m25p80.c
@ 2010-10-30 4:04 Andres Salomon
2010-10-30 5:57 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Andres Salomon @ 2010-10-30 4:04 UTC (permalink / raw)
To: Grant Likely
Cc: devicetree-discuss, linux-mtd, Mingkai Hu, David Woodhouse,
linux-kernel
While building an x86 distro kernel, I hit the following:
Kernel: arch/x86/boot/bzImage is ready (#7)
ERROR: "of_mtd_parse_partitions" [drivers/mtd/devices/m25p80.ko]
undefined!
of_mtd_parse_partitions is defined with MTD_OF_PARTS, and that's only
built on PPC and microblaze. The code in question should be wrapped w/
a stricter #ifdef.
Signed-off-by: Andres Salomon <dilinger@queued.net>
---
drivers/mtd/devices/m25p80.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index ea22520..184ddd5 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -924,7 +924,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
nr_parts = data->nr_parts;
}
-#ifdef CONFIG_OF
+#ifdef CONFIG_MTD_OF_PARTS
if (nr_parts <= 0 && spi->dev.of_node) {
nr_parts = of_mtd_parse_partitions(&spi->dev,
spi->dev.of_node, &parts);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: mtd: fix build error in m25p80.c
2010-10-30 4:04 mtd: fix build error in m25p80.c Andres Salomon
@ 2010-10-30 5:57 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2010-10-30 5:57 UTC (permalink / raw)
To: Andres Salomon
Cc: devicetree-discuss, linux-mtd, Mingkai Hu, David Woodhouse,
linux-kernel
On Fri, Oct 29, 2010 at 09:04:19PM -0700, Andres Salomon wrote:
>
> While building an x86 distro kernel, I hit the following:
>
> Kernel: arch/x86/boot/bzImage is ready (#7)
> ERROR: "of_mtd_parse_partitions" [drivers/mtd/devices/m25p80.ko]
> undefined!
>
> of_mtd_parse_partitions is defined with MTD_OF_PARTS, and that's only
> built on PPC and microblaze. The code in question should be wrapped w/
> a stricter #ifdef.
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
> ---
> drivers/mtd/devices/m25p80.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index ea22520..184ddd5 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -924,7 +924,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
> nr_parts = data->nr_parts;
> }
>
> -#ifdef CONFIG_OF
> +#ifdef CONFIG_MTD_OF_PARTS
> if (nr_parts <= 0 && spi->dev.of_node) {
> nr_parts = of_mtd_parse_partitions(&spi->dev,
> spi->dev.of_node, &parts);
True; but CONFIG_MTD_OF_PARTS should be built on all architectures
when CONFIG_OF & CONFIG_MTD_PARTITIONS is set. I'll craft a patch.
g.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-30 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-30 4:04 mtd: fix build error in m25p80.c Andres Salomon
2010-10-30 5:57 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).