From: Stefan Roese <sr@denx.de>
To: "Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 1/5] MTD: make MTD_CONCAT support mandatory
Date: Wed, 12 Jan 2011 14:25:49 +0100 [thread overview]
Message-ID: <201101121425.49587.sr@denx.de> (raw)
In-Reply-To: <1294745619-7142-1-git-send-email-dbaryshkov@gmail.com>
On Tuesday 11 January 2011 12:33:35 Dmitry Eremin-Solenikov wrote:
> Move mtdconcat to be an integral part of the mtd core. It's a tiny bit
> of code, which bears 'say Y if you don't know what to do' note in the
> Kconfig. OTOH there are several ugly ifdefs depending on the MTD_CONCAT.
> So, making MTD_CONCAT support mandatory will allow us to clean up code a
> lot.
>
> Kconfig entry is changed to be a bool defaulting to Y, so all code
> pieces depending on it, will have MTD_CONCAT Kconfig symbol and
> CONFIG_MTD_CONCAT define. This will be removed in one of next patches.
Whole patch series looks good. Thanks. I'm not sure if it makes more sense to
squash the MTD patches into one patch. Either way I'm fine with it, so:
Acked-by: Stefan Roese <sr@denx.de>
for the whole patch series.
Cheers,
Stefan
next prev parent reply other threads:[~2011-01-12 13:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 11:33 [PATCH 1/5] MTD: make MTD_CONCAT support mandatory Dmitry Eremin-Solenikov
2011-01-11 11:33 ` [PATCH 2/5] MTD: drop MTD_CONCAT dependencies from Kconfig Dmitry Eremin-Solenikov
2011-01-11 11:33 ` [PATCH 3/5] MTD: drop CONFIG_MTD_CONCAT ifdefs Dmitry Eremin-Solenikov
2011-01-11 11:33 ` [PATCH 4/5] CRIS: stop checking for MTD_CONCAT Dmitry Eremin-Solenikov
2011-01-12 12:40 ` Jesper Nilsson
2011-01-12 12:41 ` Dmitry Eremin-Solenikov
2011-01-18 11:05 ` Artem Bityutskiy
2011-01-18 14:58 ` Jesper Nilsson
2011-07-09 7:37 ` SV: " Mikael Starvik
2011-01-11 11:33 ` [PATCH 5/5] MTD: drop MTD_CONCAT from Kconfig entirely Dmitry Eremin-Solenikov
2011-01-12 13:25 ` Stefan Roese [this message]
2011-02-15 14:07 ` [PATCH 1/5] MTD: make MTD_CONCAT support mandatory Dmitry Eremin-Solenikov
2011-02-25 8:47 ` Artem Bityutskiy
2011-02-25 10:05 ` Dmitry Eremin-Solenikov
2011-02-25 10:15 ` Artem Bityutskiy
2011-02-25 10:35 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101121425.49587.sr@denx.de \
--to=sr@denx.de \
--cc=dbaryshkov@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).