public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: linux-mtd@lists.infradead.org
Cc: Ilya Yanok <yanok@emcraft.com>
Subject: Re: [RFC] Handling of errors for AMD NOR (cfi_cmdset_0002) chips
Date: Thu, 24 Mar 2011 08:45:04 +0100	[thread overview]
Message-ID: <201103240845.04902.alexander.stein@systec-electronic.com> (raw)
In-Reply-To: <4D797E23.6070409@emcraft.com>

Hello,

On Friday 11 March 2011, 02:42:59 Ilya Yanok wrote:
> current cfi_cmdset_0002.c code does not implement handling of error
> statuses reported by the chip during write/erase and just waits for a
> software timeout instead.
> 
> We think that proper handling of these conditions could help us to debug
> the issue we have with the NOR flash and UBIFS so we'd like to implement
> such handling.
> 
> I've tried to do this, please see my initial patch below. For now errors
> are just reported via pr_debug().
> 
> I'd like to hear any comments. Am I doing things right or not? Maybe I'm
> missing something?

I'm not that much into these cfi commands, but does this status check address 
immediate finished flash erases?
Let me explain: We have a NOR-Flash partition used for UBIFS. We noticed 
ubiformat takes about 11 minutes to format it (~100MiB). In u-boot ubi create 
takes about 2 _seconds_ iff the partition has been erased before.
If the flash hasn't been erased before it takes about the same time.
It seems u-boot can detect if the flash is already ready after invoking a 
erase command on an empty sector while linux doesn't.
I once checked the erase/format time for 1 sector in ubiformat:
non-empty sector: ~1s
empty-sector:    0.5s

Regards,
Alexander

  parent reply	other threads:[~2011-03-24  7:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11  1:42 [RFC] Handling of errors for AMD NOR (cfi_cmdset_0002) chips Ilya Yanok
2011-03-11  8:25 ` Norbert van Bolhuis
2011-03-23 15:47   ` Detlev Zundel
2011-03-23 17:33     ` Artem Bityutskiy
2011-03-24  7:35     ` Norbert van Bolhuis
2011-03-24  9:27       ` Detlev Zundel
2011-03-24 10:48         ` Norbert van Bolhuis
2011-03-15  8:01 ` Markus Niebel
2011-03-23 16:16   ` Detlev Zundel
2011-03-23 18:27   ` Ilya Yanok
2011-03-24  7:45 ` Alexander Stein [this message]
2011-03-24  7:55   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103240845.04902.alexander.stein@systec-electronic.com \
    --to=alexander.stein@systec-electronic.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=yanok@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox