From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-px0-f171.google.com ([209.85.212.171]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QMw1v-00011r-I5 for linux-mtd@lists.infradead.org; Thu, 19 May 2011 05:44:16 +0000 Received: by pxi7 with SMTP id 7so1601921pxi.30 for ; Wed, 18 May 2011 22:44:13 -0700 (PDT) Date: Thu, 19 May 2011 06:44:05 +0100 From: Jamie Iles To: Artem Bityutskiy Subject: Re: [RFC PATCH 0/7] Removing CONFIG_MTD_PARTITIONS Message-ID: <20110519054405.GB32183@pulham.picochip.com> References: <1305206818-31752-1-git-send-email-jamie@jamieiles.com> <1305551060.2630.2.camel@localhost> <20110516143710.GA5123@pulham.picochip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110516143710.GA5123@pulham.picochip.com> Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 16, 2011 at 03:37:10PM +0100, Jamie Iles wrote: > On Mon, May 16, 2011 at 04:04:20PM +0300, Artem Bityutskiy wrote: > > On Thu, 2011-05-12 at 14:26 +0100, Jamie Iles wrote: > > > This patch series is an RFC for the removal of CONFIG_MTD_PARTITIONS. > > > Partitioning is still supported, but is always compiled in if CONFIG_MTD is > > > selected. To transition, two new symbols are introduced - > > > mtd_device_{,un}register() that replace add_mtd_device(), add_mtd_partitions() > > > and their counterparts. The series converts a number of drivers over to use > > > these new interfaces and the final patch removes the old symbols. > > > > > > Note that this patch does not transition all of the drivers so is incomplete > > > (and not signed off!). If this approach is suitable then I'll convert all of > > > the other drivers over. > > > > Jamie, looks very good at the first glance, thanks a lot! > > Great! I'm travelling at the moment so can't complete the series, but > I'll aim to do the full series over the next few weeks and repost. > Thanks for taking the time to look at it. Artem, with regards to submitting a series for this, how would you prefer it? I imagined a few patches for the core MTD stuff then one per driver to remove the CONFIG_MTD_PARTITIONS preprocessor and convert to mtd_device_register(). There are other drivers that don't use CONFIG_MTD_PARTITIONS but use add_mtd_device()/add_mtd_partitions() etc so these just need a substitution for mtd_device_register(). Are these last ones OK as one patch or one per driver? Jamie