From: Jamie Iles <jamie@jamieiles.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Chuanxiao Dong <chuanxiao.dong@intel.com>
Subject: Re: [PATCHv2 1/6] nand/denali: convert to dev_() printk helpers
Date: Mon, 6 Jun 2011 14:22:16 +0100 [thread overview]
Message-ID: <20110606132216.GJ11191@pulham.picochip.com> (raw)
In-Reply-To: <1307365915.3112.68.camel@localhost>
On Mon, Jun 06, 2011 at 04:11:55PM +0300, Artem Bityutskiy wrote:
> On Fri, 2011-06-03 at 11:32 +0100, Jamie Iles wrote:
> > if ((data_invalid - acc_clks * CLK_X) < 2)
> > - dev_warn(denali->dev, "%s, Line %d: Warning!\n",
> > - __FILE__, __LINE__);
> > + dev_warn(denali->dev, "%s, Line %d: Warning!\n", __FILE__,
> > + __LINE__);
>
> Do you really need __FILE__ and __LINE__ here? And may be you could also
> change the warning message? Just printing "warning!" is a bit silly.
OK, fair point (and the rest of your comments). I'll respin this and
try to rationalise the messages at the same time.
Jamie
next prev parent reply other threads:[~2011-06-06 13:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 10:32 [PATCHv2 0/6] Further Denali NAND enhancements Jamie Iles
2011-06-03 10:32 ` [PATCHv2 1/6] nand/denali: convert to dev_() printk helpers Jamie Iles
2011-06-06 13:11 ` Artem Bityutskiy
2011-06-06 13:22 ` Jamie Iles [this message]
2011-06-06 13:51 ` Jamie Iles
2011-06-06 15:35 ` Artem Bityutskiy
2011-06-03 10:32 ` [PATCHv2 2/6] nand/denali: annotate pci init/exit functions with correct section Jamie Iles
2011-06-06 13:16 ` Artem Bityutskiy
2011-06-03 10:32 ` [PATCHv2 3/6] nand/denali: allow the number of ECC bits to be set by pdata Jamie Iles
2011-06-03 10:32 ` [PATCHv2 4/6] nand/denali: support hardware with internal ECC fixup Jamie Iles
2011-06-03 10:32 ` [PATCHv2 5/6] nand/denali: support MTD partitioning Jamie Iles
2011-06-03 10:32 ` [PATCHv2 6/6] mtd/denali: support for cmdline partitioning Jamie Iles
2011-06-06 13:18 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606132216.GJ11191@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=chuanxiao.dong@intel.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox