* [patch] ubifs: dereferencing an ERR_PTR in ubifs_mount()
@ 2011-06-20 7:10 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-06-20 7:10 UTC (permalink / raw)
To: Al Viro; +Cc: Adrian Hunter, linux-mtd, dedekind1
d251ed271d5 "ubifs: fix sget races" left out the goto from this
error path so the static checkers complain that we're dereferencing
"sb" when it's an ERR_PTR.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 8c892c2..529be05 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2146,6 +2146,7 @@ static struct dentry *ubifs_mount(struct file_system_type *fs_type, int flags,
if (IS_ERR(sb)) {
err = PTR_ERR(sb);
kfree(c);
+ goto out_close;
}
if (sb->s_root) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-20 7:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-20 7:10 [patch] ubifs: dereferencing an ERR_PTR in ubifs_mount() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).