From: Randy Dunlap <randy.dunlap@oracle.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
dedekind1@gmail.com, linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
linux-next@vger.kernel.org, linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/2] mtd: make ofpart buildable as a separate module
Date: Sun, 26 Jun 2011 16:29:08 -0700 [thread overview]
Message-ID: <20110626162908.2f783471.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1309122180-12838-2-git-send-email-dbaryshkov@gmail.com>
On Mon, 27 Jun 2011 01:02:59 +0400 Dmitry Eremin-Solenikov wrote:
> As ofpart now uses a standard mtd partitions parser interface, make it
> buildable as a separate module. Also provide MODULE_DESCRIPTION and
> MODULE_AUTHOR for this module.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
> ---
> drivers/mtd/Kconfig | 3 ++-
> drivers/mtd/Makefile | 2 +-
> drivers/mtd/ofpart.c | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> index 4be8373..cc02e21 100644
> --- a/drivers/mtd/Kconfig
> +++ b/drivers/mtd/Kconfig
> @@ -137,7 +137,8 @@ config MTD_AFS_PARTS
> 'physmap' map driver (CONFIG_MTD_PHYSMAP) does this, for example.
>
> config MTD_OF_PARTS
> - def_bool y
> + tristate "OpenFirmware partitioning information support"
> + default Y
> depends on OF
> help
> This provides a partition parsing function which derives
> diff --git a/drivers/mtd/Makefile b/drivers/mtd/Makefile
> index 39664c4..9aaac3a 100644
> --- a/drivers/mtd/Makefile
> +++ b/drivers/mtd/Makefile
> @@ -5,8 +5,8 @@
> # Core functionality.
> obj-$(CONFIG_MTD) += mtd.o
> mtd-y := mtdcore.o mtdsuper.o mtdconcat.o mtdpart.o
> -mtd-$(CONFIG_MTD_OF_PARTS) += ofpart.o
>
> +obj-$(CONFIG_MTD_OF_PARTS) += ofpart.o
> obj-$(CONFIG_MTD_REDBOOT_PARTS) += redboot.o
> obj-$(CONFIG_MTD_CMDLINE_PARTS) += cmdlinepart.o
> obj-$(CONFIG_MTD_AFS_PARTS) += afs.o
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 41c4518..aa33b8a 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -174,3 +174,5 @@ out:
> module_init(ofpart_parser_init);
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Parser for MTD partitioning information in device tree");
> +MODULE_AUTHOR("Vitaly Wool, David Gibson");
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-06-26 23:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 21:02 [PATCH 0/2] finish modularization of ofpart parser Dmitry Eremin-Solenikov
2011-06-26 21:02 ` [PATCH 1/2] mtd: make ofpart buildable as a separate module Dmitry Eremin-Solenikov
2011-06-26 23:29 ` Randy Dunlap [this message]
2011-06-27 5:49 ` Artem Bityutskiy
2011-06-26 21:03 ` [PATCH 2/2] mtd/ofpart: add ofoldpart alias Dmitry Eremin-Solenikov
2011-06-26 23:35 ` Grant Likely
2011-06-27 5:45 ` Artem Bityutskiy
2011-06-27 5:51 ` Dmitry Eremin-Solenikov
2011-06-27 6:03 ` Artem Bityutskiy
2011-06-27 12:34 ` Dmitry Eremin-Solenikov
2011-06-28 7:41 ` Artem Bityutskiy
2011-06-28 8:09 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110626162908.2f783471.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=dbaryshkov@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox