From: Wolfram Sang <w.sang@pengutronix.de>
To: "Jürgen Lambrecht" <juergen.lambrecht@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Add 'config IMX_NFC_V1_BISWAP' to swap the Bad block Indicator, and use for imx27pdk nand support.
Date: Wed, 6 Jul 2011 11:06:37 +0200 [thread overview]
Message-ID: <20110706090637.GA2117@pengutronix.de> (raw)
In-Reply-To: <1309872828-13942-1-git-send-email-J.Lambrecht@televic.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
> + temp1 = *((volatile unsigned short*)(host->main_area0 + 0x7D0));
> + temp2 = *((volatile unsigned short*)(host->main_area0 + 0x834));
> + new_temp1 = (temp1 & 0xFF00) | (temp2 >> 8);
> + temp2 = (temp2 & 0x00FF) | (temp1 << 8);
> + *((volatile unsigned short*)(host->main_area0 + 0x7D0)) = new_temp1;
> + *((volatile unsigned short*)(host->main_area0 + 0x834)) = temp2;
Please use proper io-accessors and no magic values in V2.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2011-07-06 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 13:33 [PATCH] Add 'config IMX_NFC_V1_BISWAP' to swap the Bad block Indicator, and use for imx27pdk nand support Jürgen Lambrecht
2011-07-05 15:52 ` Baruch Siach
2011-07-06 7:06 ` Artem Bityutskiy
2011-07-06 8:09 ` Sascha Hauer
2011-07-06 8:55 ` Lambrecht Jürgen
2011-07-06 9:30 ` Lambrecht Jürgen
2011-07-06 11:48 ` Lothar Waßmann
2011-07-06 11:56 ` Artem Bityutskiy
2011-07-06 12:39 ` Lambrecht Jürgen
2011-07-06 13:53 ` Lothar Waßmann
2011-07-06 16:29 ` Sascha Hauer
2011-07-06 16:48 ` Lothar Waßmann
2011-07-06 12:05 ` Sascha Hauer
2011-07-06 12:25 ` Lothar Waßmann
2011-07-06 9:06 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706090637.GA2117@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=juergen.lambrecht@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox