From: Matthew Garrett <mjg@redhat.com>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: "dzickus@redhat.com" <dzickus@redhat.com>,
Satoru Moriya <satoru.moriya@hds.com>,
"dle-develop@lists.sourceforge.net"
<dle-develop@lists.sourceforge.net>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Jarod Wilson <jwilson@redhat.com>,
Americo Wang <xiyou.wangcong@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [RFC][PATCH -mmotm 1/4] Add static function calls of pstore to kexec path
Date: Tue, 19 Jul 2011 19:35:07 +0100 [thread overview]
Message-ID: <20110719183506.GA23770@srcf.ucam.org> (raw)
In-Reply-To: <5C4C569E8A4B9B42A84A977CF070A35B2C199C64C3@USINDEVS01.corp.hds.com>
On Tue, Jul 19, 2011 at 02:24:27PM -0400, Seiji Aguchi wrote:
> - mutex_lock(&psinfo->buf_mutex);
> + switch (reason) {
> + case KMSG_DUMP_KEXEC:
> + /* Skip if there is no driver or there is a driver calling
> + pstore_register() */
> + if (!psinfo || !spin_trylock(&pstore_lock))
> + return;
> + break;
> + default:
> + mutex_lock(&psinfo->buf_mutex);
How is this safe? What happens if there's a pstore access in process
when you hit this codepath?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-07-19 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 18:24 [RFC][PATCH -mmotm 1/4] Add static function calls of pstore to kexec path Seiji Aguchi
2011-07-19 18:35 ` Matthew Garrett [this message]
2011-07-19 18:48 ` Seiji Aguchi
2011-07-19 18:52 ` Matthew Garrett
2011-07-19 19:14 ` Seiji Aguchi
2011-07-19 19:27 ` Matthew Garrett
2011-07-19 19:40 ` Matthew Garrett
2011-07-19 18:54 ` Don Zickus
2011-07-19 19:02 ` Vivek Goyal
2011-07-19 19:20 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719183506.GA23770@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jwilson@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox