From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 19 Jul 2011 15:20:25 -0400 From: Don Zickus To: Vivek Goyal Subject: Re: [RFC][PATCH -mmotm 1/4] Add static function calls of pstore to kexec path Message-ID: <20110719192025.GB3400@redhat.com> References: <5C4C569E8A4B9B42A84A977CF070A35B2C199C64C3@USINDEVS01.corp.hds.com> <20110719183506.GA23770@srcf.ucam.org> <5C4C569E8A4B9B42A84A977CF070A35B2C199C64D6@USINDEVS01.corp.hds.com> <20110719185411.GA3400@redhat.com> <20110719190212.GA4844@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110719190212.GA4844@redhat.com> Cc: Satoru Moriya , "dle-develop@lists.sourceforge.net" , "tony.luck@intel.com" , "hpa@zytor.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "Eric W. Biederman" , KOSAKI Motohiro , Jarod Wilson , Americo Wang , Andrew Morton , Seiji Aguchi , Matthew Garrett List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jul 19, 2011 at 03:02:12PM -0400, Vivek Goyal wrote: > > Another interesting question is do we need to log anything in the kdump > > path? Isn't kdump generating the same info? What added value do we get > > over kdump? > > I had the same question. The argument is that kdump can fail and they > can not afford to not capture any info at all. So before kdump executes > they want to save some state to NVRAM. > > I am wondering that saving this info to NVRAM, can it be done early in > second kernel? I guess we are not supposed to take any EFI services in > second kernel so it might not be possible. Actually the write to NVRAM wouldn't be so bad if ERST supported it. It would just be an equvialent to a memcpy. Currently it uses a complicated state machine to a persistent storage which complicates things. As a result I get nervous if ERST firmware issues would block us from executing kdump. Cheers, Don