From: Yauhen Kharuzhy <yauhen.kharuzhy@promwad.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Viktar Palstsiuk <viktar.palstsiuk@promwad.com>,
Ben Gardiner <bengardiner@nanometrics.ca>,
linux-mtd@lists.infradead.org
Subject: Re: UBI FS on 2MiB eraseblock Hynix MLC NAND
Date: Tue, 16 Aug 2011 11:30:36 +0300 [thread overview]
Message-ID: <20110816083035.GA8459@jeknote.loshitsa1.net> (raw)
In-Reply-To: <1313482105.5993.1.camel@sauron>
On Tue, Aug 16, 2011 at 11:08:20AM +0300, Artem Bityutskiy wrote:
> Hi,
>
> On Tue, 2011-08-16 at 10:48 +0300, Viktar Palstsiuk wrote:
> > The problem was caused by behavior of H27UBG8T2ATR Hynix MLC NAND
> > while UBI FS was trying to do page write operation. UBI FS was trying
> > to write data to the first empty page assuming that 0xFF page is
> > erased and writable. But this type of NAND returns error on page write
> > operation even if it was entirely written with 0xFF before. As far as
> > I'm using U-boot's 'nand write' to flash UBI image I've added skip if
> > U-boot trying to write 0xFF-page.
> >
> > --- drivers/mtd/nand/nand_base.c
> > +++ drivers/mtd/nand/nand_base.c (working copy)
> > @@ -1761,7 +1761,18 @@
> > const uint8_t *buf, int page, int cached, int raw)
> > {
> > int status;
> > + int i;
> >
> > + /* Skip empty page */
> > + for (i = 0; i < mtd->writesize; i++)
> > + if (buf[i] != 0xFF)
> > + break;
> > +
> > + if (i == mtd->writesize) {
> > + printf ("nand_write_page: Skip 0xFF page\n");
> > + return 0;
> > + }
> > +
>
> This solution is not acceptable as we are currently discussing in the
> "GPMI-NAND Status" thread in this mailing list.
>
> Instead, you should just change u-boot, and I believe someone has done
> this recently - ask the u-boot mailing list. I think that was Ben -
> CCed.
As I understood, above Victor's patch is for U-Boot, not for kernel.
--
Yauhen Kharuzhy
-----------------------------------------------------------
Promwad Innovation Company
22, Olshevskogo St.
Office 809
220073, Minsk, Belarus
Phone/Fax: +375 (17) 312-1246
E-mail: yauhen.kharuzhy@promwad.com
Skype: jekhor
Web: www.promwad.com
next prev parent reply other threads:[~2011-08-16 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 13:59 UBI FS on 2MiB eraseblock Hynix MLC NAND Viktar Palstsiuk
2011-08-15 16:01 ` Artem Bityutskiy
2011-08-16 7:48 ` Viktar Palstsiuk
2011-08-16 8:08 ` Artem Bityutskiy
2011-08-16 8:30 ` Yauhen Kharuzhy [this message]
2011-08-16 8:49 ` Viktar Palstsiuk
2011-08-22 13:10 ` Ben Gardiner
2011-08-16 8:13 ` Viktar Palstsiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816083035.GA8459@jeknote.loshitsa1.net \
--to=yauhen.kharuzhy@promwad.com \
--cc=bengardiner@nanometrics.ca \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=viktar.palstsiuk@promwad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox