From: "Jörn Engel" <joern@logfs.org>
To: "Fache, Herve" <h-fache@ti.com>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: Make phram work with kernel cmdline args when built-in
Date: Fri, 14 Oct 2011 16:38:16 +0200 [thread overview]
Message-ID: <20111014143816.GA32633@logfs.org> (raw)
In-Reply-To: <CA+Xn3W2P_+xdwwrvcBKREZmsj2O6=GOfyaywW-N2HhGwo0WzVg@mail.gmail.com>
On Fri, 14 October 2011 15:42:09 +0200, Fache, Herve wrote:
> 2011/10/14 Artem Bityutskiy <dedekind1@gmail.com>
>
> > Please, send patches inline. Also, try to make sure you do not
> > have many of these #ifdef MODULE sections.
>
> Also, I have tried to make my patch look like the other patch to block2mtd,
> as asked by Jörn, which explains the number of #ifdef MODULE sections...
If there were a way to get rid of the #ifdefs, I would certainly be in
favor of that. While I am happy with the functional improvements, I
would be even happier if the code looked less scarred.
I wonder how everyone else does it. Those two driver surely can't be
the only ones that depend on module parameters for initialization.
Jörn
--
Fools ignore complexity. Pragmatists suffer it.
Some can avoid it. Geniuses remove it.
-- Perlis's Programming Proverb #58, SIGPLAN Notices, Sept. 1982
next prev parent reply other threads:[~2011-10-14 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 9:46 Make phram work with kernel cmdline args when built-in Fache, Herve
2011-10-12 16:48 ` Jörn Engel
2011-10-13 13:30 ` Fache, Herve
2011-10-14 13:03 ` Artem Bityutskiy
2011-10-14 13:44 ` Fache, Herve
2011-10-16 11:55 ` Artem Bityutskiy
[not found] ` <CA+Xn3W2P_+xdwwrvcBKREZmsj2O6=GOfyaywW-N2HhGwo0WzVg@mail.gmail.com>
2011-10-14 14:38 ` Jörn Engel [this message]
2011-10-14 14:48 ` Fache, Herve
2011-10-14 15:18 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014143816.GA32633@logfs.org \
--to=joern@logfs.org \
--cc=dedekind1@gmail.com \
--cc=h-fache@ti.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox