From: "Jörn Engel" <joern@logfs.org>
To: h-fache@ti.com
Cc: joern@lazybastard.org, linux-mtd@lists.infradead.org,
dedekind1@gmail.com
Subject: Re: [PATCH] phram: make kernel boot command line arguments work
Date: Tue, 18 Oct 2011 02:32:15 +0200 [thread overview]
Message-ID: <20111018003215.GB31782@logfs.org> (raw)
In-Reply-To: <1318866038-11781-1-git-send-email-h-fache@ti.com>
On Mon, 17 October 2011 17:40:38 +0200, h-fache@ti.com wrote:
> From: Hervé Fache <h-fache@ti.com>
>
> This patch is based on Ville Herva's similar patch to block2mtd.
>
> Trying to pass kernel command line arguments at boot-time did not work, as
> phram_setup() was called so early that kmalloc() was not functional.
>
> This patch only saves the option string at the early boot stage, and parses
> it later when init_phram() is called. This is determined by the fact that
> init was called, or not.
>
> With this patch, I can boot with a statically-compiled phram, and mount a
> ext2 root fs from physical RAM, without the need for a initrd.
>
> Signed-off-by: Hervé Fache <h-fache@ti.com>
I like it.
Acked-by: Joern Engel <joern@logfs.org>
Dedekind, can I leave it to you to merge this? And Hervé, can I
motivate you to remove the #ifdef MODULE parts from block2mtd as well?
If someone complains about increased binary size, I am willing to look
for ten bytes to remove elsewhere as a trade-off.
Jörn
--
Computer system analysis is like child-rearing; you can do grievous damage,
but you cannot ensure success."
-- Tom DeMarco
next prev parent reply other threads:[~2011-10-18 0:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 15:40 [PATCH] phram: make kernel boot command line arguments work h-fache
2011-10-18 0:32 ` Jörn Engel [this message]
2011-10-18 8:05 ` Fache, Herve
2011-10-20 16:34 ` Artem Bityutskiy
2011-10-20 16:16 ` Artem Bityutskiy
2011-10-21 8:51 ` Fache, Herve
2011-10-25 7:37 ` Artem Bityutskiy
2011-10-25 9:09 ` Fache, Herve
2011-10-25 19:58 ` Jörn Engel
2011-10-29 20:10 ` Artem Bityutskiy
2011-10-20 16:20 ` Artem Bityutskiy
2011-10-21 8:49 ` Fache, Herve
2011-10-25 7:32 ` Artem Bityutskiy
2011-10-25 9:07 ` Fache, Herve
2011-10-29 20:09 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018003215.GB31782@logfs.org \
--to=joern@logfs.org \
--cc=dedekind1@gmail.com \
--cc=h-fache@ti.com \
--cc=joern@lazybastard.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).