From: Dan Carpenter <dan.carpenter@oracle.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [patch] mtd/docg3: fix error handling in docg3_probe()
Date: Thu, 24 Nov 2011 13:31:47 +0300 [thread overview]
Message-ID: <20111124103147.GF3195@mwanda> (raw)
In-Reply-To: <87pqghygbv.fsf@free.fr>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On Thu, Nov 24, 2011 at 11:17:56AM +0100, Robert Jarzmik wrote:
> > if (!found)
> > @@ -1138,9 +1141,11 @@ notfound:
> > ret = -ENODEV;
> > dev_info(dev, "No supported DiskOnChip found\n");
> > err_probe:
> > - for (floor = 0; floor < DOC_MAX_NBFLOORS; floor++)
> > + for (floor = 0; floor < DOC_MAX_NBFLOORS; floor++) {
> > if (docg3_floors[floor])
> > doc_release_device(docg3_floors[floor]);
> > + }
> > + kfree(docg3_floors);
> This is in conflict. Could you drop that hunk and wait for the other patch to go
> upstream ? Or alternatively use the whole serie in [2] as your base ?
> I think some patches of the serie didn't make it in the tree you're
> using.
>
I'm on linux-next. They're all going to hit linux next soon right?
I can redo the patch later in that case.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-24 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 7:21 [patch] mtd/docg3: fix error handling in docg3_probe() Dan Carpenter
2011-11-24 9:02 ` walter harms
2011-11-24 9:31 ` Dan Carpenter
2011-11-24 10:17 ` Robert Jarzmik
2011-11-24 10:31 ` Dan Carpenter [this message]
2011-11-24 21:00 ` Robert Jarzmik
2011-11-24 21:08 ` Artem Bityutskiy
2011-11-24 21:29 ` Artem Bityutskiy
2011-11-26 10:58 ` Robert Jarzmik
2011-11-28 13:53 ` [patch v2] mtd/docg3: dereferencing an ERR_PTR() " Dan Carpenter
2011-11-29 22:00 ` Robert Jarzmik
2011-12-01 8:02 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124103147.GF3195@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox