From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 0/5] MTD: modify mtd api to return bitflip info on read operations
Date: Wed, 30 Nov 2011 18:06:08 +0100 [thread overview]
Message-ID: <20111130180608.1a8c687d@skate> (raw)
In-Reply-To: <4ED66140.8020008@newsguy.com>
Hello,
Le Wed, 30 Nov 2011 09:00:48 -0800,
Mike Dunn <mikedunn@newsguy.com> a écrit :
> Thanks Thomas. For some reason this post never made it to my inbox. Pasted from the list archive...
Huh, strange. Let's see if this one reaches your Inbox.
> > Making this change in patch 1 will break the build if someone bisects
> > kernel changes between patch 1 and your other patches.
>
> Then I guess it should be a single patch. As a general rule, should individual patches
> not be interdependent?
My understanding is that the kernel should be buildable at any given
point, so that things such as "git bisect" can easily be used. So, it's
not so much a "interdependence" question but rather a "buildability"
question.
Basically, you have to ensure that the kernel still builds when patch 1
is enabled, when patches 1+2 are enabled, when patches 1+2+3 are
enabled, etc.
> Well, then it wouldn't be a generic mtd read operation, and higher layers would have to be
> aware of the type of device and call the appropriate read function.
> Fewer drivers would need to be patched, but patches to infrastructure code would be complicated
> and make the resulting code ugly, I think.
True that having some drivers implementing the standard ->read()
method and some others implementing the extended ->readext() method
would be ugly.
> I'm not a flash expert, but I think that the greatest number of bitflips on any one page
> is a sufficient diagnostic of the integrity of an eraseblock. One bad page will make the
> entire eraseblock unusable, so I'm not sure it's useful to report bitflips for specific pages.
Ok, understood, that makes sense to me (but I'm not a flash expert
either).
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-11-30 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 17:27 [PATCH 0/5] MTD: modify mtd api to return bitflip info on read operations Mike Dunn
2011-11-30 17:06 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-29 0:58 Mike Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130180608.1a8c687d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox