From: Marek Vasut <marek.vasut@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: Huang Shijie <b32955@freescale.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] mtd: gpmi: add missing include 'module.h'
Date: Fri, 2 Dec 2011 20:47:01 +0100 [thread overview]
Message-ID: <201112022047.01444.marek.vasut@gmail.com> (raw)
In-Reply-To: <1322060226-5208-1-git-send-email-w.sang@pengutronix.de>
> Fixes:
>
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE'
> undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration
> specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition
> has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to
> 'int' in declaration of 'MODULE_AUTHOR'
>
> and some more...
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 071b634..493ec2f 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -21,9 +21,9 @@
> #include <linux/clk.h>
> #include <linux/slab.h>
> #include <linux/interrupt.h>
> +#include <linux/module.h>
> #include <linux/mtd/gpmi-nand.h>
This one is missing too, but I suspect that's the stuff discussed in the
subsequent emails? When do you plan to get this merged? (or what do I need to
apply by hand ... patch name or message ID is ok).
Thanks
M
next prev parent reply other threads:[~2011-12-02 19:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 14:57 [PATCH] mtd: gpmi: add missing include 'module.h' Wolfram Sang
2011-11-24 3:01 ` Huang Shijie
2011-11-24 7:53 ` Wolfram Sang
2011-11-24 8:58 ` Huang Shijie
2011-11-29 22:20 ` Artem Bityutskiy
2011-12-02 19:47 ` Marek Vasut [this message]
2011-12-05 6:34 ` Artem Bityutskiy
2011-12-13 22:15 ` Marek Vasut
2011-12-17 15:54 ` Artem Bityutskiy
2011-12-17 23:19 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112022047.01444.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).