From: Wolfram Sang <w.sang@pengutronix.de>
To: Barry Song <Barry.Song@csr.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, workgroup.linux@csr.com,
Erik Gilling <konkers@google.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-mtd@lists.infradead.org, Barry Song <Baohua.Song@csr.com>,
David Woodhouse <dwmw2@infradead.org>,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 1/3] platform: add common resource requesting and mapping helper
Date: Tue, 31 Jan 2012 11:17:34 +0100 [thread overview]
Message-ID: <20120131101734.GE2471@pengutronix.de> (raw)
In-Reply-To: <1328004002-24646-2-git-send-email-Barry.Song@csr.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Tue, Jan 31, 2012 at 06:00:00PM +0800, Barry Song wrote:
> From: Barry Song <Baohua.Song@csr.com>
>
> this patch helps to move the common pattern from
>
> "
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res) {
> ret = -ENODEV;
> goto err;
> }
You don't need to do the error checking for 'res'. You can simply do
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
base = devm_request_and_ioremap(&dev->dev, res);
devm_request_and_ioremap() will check res. Given that, I don't think
we can save a lot with another wrapper.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-01-31 10:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 9:59 [PATCH 0/3] platform: add platform_devm_request_and_ioremap() common API Barry Song
2012-01-31 10:00 ` [PATCH 1/3] platform: add common resource requesting and mapping helper Barry Song
2012-01-31 10:17 ` Wolfram Sang [this message]
2012-01-31 11:04 ` Barry Song
2012-01-31 11:33 ` Wolfram Sang
2012-01-31 12:09 ` Barry Song
2012-01-31 20:34 ` Grant Likely
2012-01-31 21:15 ` Wolfram Sang
2012-01-31 21:51 ` Grant Likely
2012-02-01 2:11 ` Barry Song
2012-02-01 10:03 ` Wolfram Sang
2012-02-01 10:20 ` Barry Song
2012-02-01 12:56 ` Mark Brown
2012-02-02 0:10 ` Grant Likely
2012-01-31 20:35 ` Grant Likely
2012-01-31 21:20 ` Linus Walleij
2012-01-31 21:52 ` Grant Likely
2012-02-01 2:22 ` Barry Song
2012-01-31 10:00 ` [PATCH 2/3] GPIO: TEGRA: move to use platform_devm_request_and_ioremap() helper Barry Song
2012-01-31 16:55 ` Stephen Warren
2012-01-31 20:37 ` Grant Likely
2012-01-31 10:00 ` [PATCH 3/3] MTD: NAND: txx9ndfmc: " Barry Song
2012-01-31 11:14 ` [PATCH 0/3] platform: add platform_devm_request_and_ioremap() common API Artem Bityutskiy
2012-01-31 12:57 ` Barry Song
2012-01-31 13:16 ` Artem Bityutskiy
2012-01-31 13:23 ` Artem Bityutskiy
2012-01-31 13:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131101734.GE2471@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=Baohua.Song@csr.com \
--cc=Barry.Song@csr.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=konkers@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox