From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-lpp01m020-f177.google.com ([209.85.217.177])
 by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux))
 id 1RsKS1-0006Au-J4
 for linux-mtd@lists.infradead.org; Tue, 31 Jan 2012 20:37:14 +0000
Received: by lbon10 with SMTP id n10so73758lbo.36
 for <linux-mtd@lists.infradead.org>; Tue, 31 Jan 2012 12:37:10 -0800 (PST)
Sender: Grant Likely <glikely@secretlab.ca>
Date: Tue, 31 Jan 2012 13:37:03 -0700
From: Grant Likely <grant.likely@secretlab.ca>
To: Barry Song <Barry.Song@csr.com>
Subject: Re: [PATCH 2/3] GPIO: TEGRA: move to use
 platform_devm_request_and_ioremap() helper
Message-ID: <20120131203703.GI22611@ponder.secretlab.ca>
References: <1328004002-24646-1-git-send-email-Barry.Song@csr.com>
 <1328004002-24646-3-git-send-email-Barry.Song@csr.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1328004002-24646-3-git-send-email-Barry.Song@csr.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
 Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org,
 workgroup.linux@csr.com, linux-mtd@lists.infradead.org,
 Barry Song <Baohua.Song@csr.com>, Erik Gilling <konkers@google.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Tue, Jan 31, 2012 at 06:00:01PM +0800, Barry Song wrote:
> From: Barry Song <Baohua.Song@csr.com>
> 
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Erik Gilling <konkers@google.com>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

This of course depends on the other patch, so I won't merge it until
there is an okay from gregkh.  Also, with his okay I'd be happy to
take it through the gpio tree to reduce dependencies.

g.


> ---
>  drivers/gpio/gpio-tegra.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index bdc2937..118e367 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -355,13 +355,7 @@ static int __devinit tegra_gpio_probe(struct platform_device *pdev)
>  		bank->irq = res->start;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(&pdev->dev, "Missing MEM resource\n");
> -		return -ENODEV;
> -	}
> -
> -	regs = devm_request_and_ioremap(&pdev->dev, res);
> +	regs = platform_devm_request_and_ioremap(pdev, 0);
>  	if (!regs) {
>  		dev_err(&pdev->dev, "Couldn't ioremap regs\n");
>  		return -ENODEV;
> -- 
> 1.7.1
> 
> 
> 
> Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
> More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog