From: "Jörn Engel" <joern@logfs.org>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/8] mtd: block2mtd: initialize writebufsize
Date: Sat, 4 Feb 2012 13:00:35 -0500 [thread overview]
Message-ID: <20120204180035.GB28736@logfs.org> (raw)
In-Reply-To: <4fe90e9a0ba750bbdb34d04ca3437b493a19277f.1328257053.git.artem.bityutskiy@linux.intel.com>
On Fri, 3 February 2012 10:43:07 +0200, Artem Bityutskiy wrote:
>
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>
> The writebufsize concept was introduce by commit
> "0e4ca7e mtd: add writebufsize field to mtd_info struct" and it represents
> the maximum amount of data the device writes to the media at a time. This is
> an important parameter for UBIFS which is used during recovery and which
> basically defines how big a corruption caused by a power cut can be.
>
> However, we forgot to set this parameter for block2mtd. Set it to PAGE_SIZE
> because this is actually the amount of data we write at a time.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Cc: stable@kernel.org [2.6.38+]
> Cc: Joern Engel <joern@lazybastard.org>
Acked-by: Joern Engel <joern@lazybastard.org>
>From the description of 0e4ca7e it appears as if using a minimum of
say 8 for ubifs recovery would have done the trick as well. Oh well!
Jörn
next prev parent reply other threads:[~2012-02-04 19:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 8:43 [PATCH 1/8] mtd: block2mtd: initialize writebufsize Artem Bityutskiy
2012-02-03 8:43 ` [PATCH 2/8] mtd: doc2000: " Artem Bityutskiy
2012-02-03 8:43 ` [PATCH 3/8] mtd: doc2001: " Artem Bityutskiy
2012-02-03 8:43 ` [PATCH 4/8] mtd: doc2001plus: " Artem Bityutskiy
2012-02-03 8:43 ` [PATCH 5/8] mtd: docg3: " Artem Bityutskiy
2012-02-03 15:44 ` Robert Jarzmik
2012-02-03 8:43 ` [PATCH 6/8] mtd: lart: " Artem Bityutskiy
2012-02-03 8:43 ` [PATCH 7/8] mtd: spear_smi: " Artem Bityutskiy
2012-02-03 8:45 ` Stefan Roese
2012-02-03 8:43 ` [PATCH 8/8] mtd: sst25l: " Artem Bityutskiy
2012-02-04 18:00 ` Jörn Engel [this message]
2012-02-06 9:07 ` [PATCH 1/8] mtd: block2mtd: " Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120204180035.GB28736@logfs.org \
--to=joern@logfs.org \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox