* [PATCH 1/2] UBI: allocate verification buffer on demand @ 2012-03-08 14:14 Artem Bityutskiy 2012-03-08 14:14 ` [PATCH 2/2] UBI: rename peb_buf1 to peb_buf Artem Bityutskiy 2012-03-08 16:08 ` [PATCH 1/2] UBI: allocate verification buffer on demand Shmulik Ladkani 0 siblings, 2 replies; 6+ messages in thread From: Artem Bityutskiy @ 2012-03-08 14:14 UTC (permalink / raw) To: MTD Maling List; +Cc: Josselin Costanzi From: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. The only reason UBI has it is to check that the data were written correctly. But we do not have to have 2 buffers for this and waste RAM - we can just compare CRC checksums instead. Artem bityutskiy: massaged the patch and commit message Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> --- drivers/mtd/ubi/build.c | 6 ------ drivers/mtd/ubi/eba.c | 6 +++--- drivers/mtd/ubi/ubi.h | 4 +--- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 115749f..6e0806b 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -949,10 +949,6 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num, int vid_hdr_offset) if (!ubi->peb_buf1) goto out_free; - ubi->peb_buf2 = vmalloc(ubi->peb_size); - if (!ubi->peb_buf2) - goto out_free; - err = ubi_debugging_init_dev(ubi); if (err) goto out_free; @@ -1030,7 +1026,6 @@ out_debugging: ubi_debugging_exit_dev(ubi); out_free: vfree(ubi->peb_buf1); - vfree(ubi->peb_buf2); if (ref) put_device(&ubi->dev); else @@ -1102,7 +1097,6 @@ int ubi_detach_mtd_dev(int ubi_num, int anyway) put_mtd_device(ubi->mtd); ubi_debugging_exit_dev(ubi); vfree(ubi->peb_buf1); - vfree(ubi->peb_buf2); ubi_msg("mtd%d is detached from ubi%d", ubi->mtd->index, ubi->ubi_num); put_device(&ubi->dev); return 0; diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index cd26da8..f548af3 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -1134,8 +1134,8 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, * We've written the data and are going to read it back to make * sure it was written correctly. */ - - err = ubi_io_read_data(ubi, ubi->peb_buf2, to, 0, aldata_size); + memset(ubi->peb_buf1, 0xFF, aldata_size); + err = ubi_io_read_data(ubi, ubi->peb_buf1, to, 0, aldata_size); if (err) { if (err != UBI_IO_BITFLIPS) { ubi_warn("error %d while reading data back " @@ -1149,7 +1149,7 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, cond_resched(); - if (memcmp(ubi->peb_buf1, ubi->peb_buf2, aldata_size)) { + if (crc != crc32(UBI_CRC32_INIT, ubi->peb_buf1, data_size)) { ubi_warn("read data back from PEB %d and it is " "different", to); err = -EINVAL; diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h index d51d75d..cb93ad9 100644 --- a/drivers/mtd/ubi/ubi.h +++ b/drivers/mtd/ubi/ubi.h @@ -388,8 +388,7 @@ struct ubi_wl_entry; * @mtd: MTD device descriptor * * @peb_buf1: a buffer of PEB size used for different purposes - * @peb_buf2: another buffer of PEB size used for different purposes - * @buf_mutex: protects @peb_buf1 and @peb_buf2 + * @buf_mutex: protects @peb_buf1 * @ckvol_mutex: serializes static volume checking when opening * * @dbg: debugging information for this UBI device @@ -472,7 +471,6 @@ struct ubi_device { struct mtd_info *mtd; void *peb_buf1; - void *peb_buf2; struct mutex buf_mutex; struct mutex ckvol_mutex; -- 1.7.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] UBI: rename peb_buf1 to peb_buf 2012-03-08 14:14 [PATCH 1/2] UBI: allocate verification buffer on demand Artem Bityutskiy @ 2012-03-08 14:14 ` Artem Bityutskiy 2012-03-08 16:08 ` [PATCH 1/2] UBI: allocate verification buffer on demand Shmulik Ladkani 1 sibling, 0 replies; 6+ messages in thread From: Artem Bityutskiy @ 2012-03-08 14:14 UTC (permalink / raw) To: MTD Maling List; +Cc: Josselin Costanzi From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Now we have only one buffer so let's rename it to just 'peb_buf1'. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> --- drivers/mtd/ubi/build.c | 8 ++++---- drivers/mtd/ubi/eba.c | 24 ++++++++++++------------ drivers/mtd/ubi/io.c | 14 +++++++------- drivers/mtd/ubi/scan.c | 8 ++++---- drivers/mtd/ubi/ubi.h | 6 +++--- 5 files changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 6e0806b..0fde9fc 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -945,8 +945,8 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num, int vid_hdr_offset) goto out_free; err = -ENOMEM; - ubi->peb_buf1 = vmalloc(ubi->peb_size); - if (!ubi->peb_buf1) + ubi->peb_buf = vmalloc(ubi->peb_size); + if (!ubi->peb_buf) goto out_free; err = ubi_debugging_init_dev(ubi); @@ -1025,7 +1025,7 @@ out_detach: out_debugging: ubi_debugging_exit_dev(ubi); out_free: - vfree(ubi->peb_buf1); + vfree(ubi->peb_buf); if (ref) put_device(&ubi->dev); else @@ -1096,7 +1096,7 @@ int ubi_detach_mtd_dev(int ubi_num, int anyway) vfree(ubi->vtbl); put_mtd_device(ubi->mtd); ubi_debugging_exit_dev(ubi); - vfree(ubi->peb_buf1); + vfree(ubi->peb_buf); ubi_msg("mtd%d is detached from ubi%d", ubi->mtd->index, ubi->ubi_num); put_device(&ubi->dev); return 0; diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index f548af3..63edee0 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -529,18 +529,18 @@ retry: data_size = offset + len; mutex_lock(&ubi->buf_mutex); - memset(ubi->peb_buf1 + offset, 0xFF, len); + memset(ubi->peb_buf + offset, 0xFF, len); /* Read everything before the area where the write failure happened */ if (offset > 0) { - err = ubi_io_read_data(ubi, ubi->peb_buf1, pnum, 0, offset); + err = ubi_io_read_data(ubi, ubi->peb_buf, pnum, 0, offset); if (err && err != UBI_IO_BITFLIPS) goto out_unlock; } - memcpy(ubi->peb_buf1 + offset, buf, len); + memcpy(ubi->peb_buf + offset, buf, len); - err = ubi_io_write_data(ubi, ubi->peb_buf1, new_pnum, 0, data_size); + err = ubi_io_write_data(ubi, ubi->peb_buf, new_pnum, 0, data_size); if (err) { mutex_unlock(&ubi->buf_mutex); goto write_error; @@ -1053,13 +1053,13 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, /* * OK, now the LEB is locked and we can safely start moving it. Since - * this function utilizes the @ubi->peb_buf1 buffer which is shared + * this function utilizes the @ubi->peb_buf buffer which is shared * with some other functions - we lock the buffer by taking the * @ubi->buf_mutex. */ mutex_lock(&ubi->buf_mutex); dbg_wl("read %d bytes of data", aldata_size); - err = ubi_io_read_data(ubi, ubi->peb_buf1, from, 0, aldata_size); + err = ubi_io_read_data(ubi, ubi->peb_buf, from, 0, aldata_size); if (err && err != UBI_IO_BITFLIPS) { ubi_warn("error %d while reading data from PEB %d", err, from); @@ -1079,10 +1079,10 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, */ if (vid_hdr->vol_type == UBI_VID_DYNAMIC) aldata_size = data_size = - ubi_calc_data_len(ubi, ubi->peb_buf1, data_size); + ubi_calc_data_len(ubi, ubi->peb_buf, data_size); cond_resched(); - crc = crc32(UBI_CRC32_INIT, ubi->peb_buf1, data_size); + crc = crc32(UBI_CRC32_INIT, ubi->peb_buf, data_size); cond_resched(); /* @@ -1121,7 +1121,7 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, } if (data_size > 0) { - err = ubi_io_write_data(ubi, ubi->peb_buf1, to, 0, aldata_size); + err = ubi_io_write_data(ubi, ubi->peb_buf, to, 0, aldata_size); if (err) { if (err == -EIO) err = MOVE_TARGET_WR_ERR; @@ -1134,8 +1134,8 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, * We've written the data and are going to read it back to make * sure it was written correctly. */ - memset(ubi->peb_buf1, 0xFF, aldata_size); - err = ubi_io_read_data(ubi, ubi->peb_buf1, to, 0, aldata_size); + memset(ubi->peb_buf, 0xFF, aldata_size); + err = ubi_io_read_data(ubi, ubi->peb_buf, to, 0, aldata_size); if (err) { if (err != UBI_IO_BITFLIPS) { ubi_warn("error %d while reading data back " @@ -1149,7 +1149,7 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, cond_resched(); - if (crc != crc32(UBI_CRC32_INIT, ubi->peb_buf1, data_size)) { + if (crc != crc32(UBI_CRC32_INIT, ubi->peb_buf, data_size)) { ubi_warn("read data back from PEB %d and it is " "different", to); err = -EINVAL; diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c index 5cde4e5..43f1a00 100644 --- a/drivers/mtd/ubi/io.c +++ b/drivers/mtd/ubi/io.c @@ -431,11 +431,11 @@ static int torture_peb(struct ubi_device *ubi, int pnum) goto out; /* Make sure the PEB contains only 0xFF bytes */ - err = ubi_io_read(ubi, ubi->peb_buf1, pnum, 0, ubi->peb_size); + err = ubi_io_read(ubi, ubi->peb_buf, pnum, 0, ubi->peb_size); if (err) goto out; - err = ubi_check_pattern(ubi->peb_buf1, 0xFF, ubi->peb_size); + err = ubi_check_pattern(ubi->peb_buf, 0xFF, ubi->peb_size); if (err == 0) { ubi_err("erased PEB %d, but a non-0xFF byte found", pnum); @@ -444,17 +444,17 @@ static int torture_peb(struct ubi_device *ubi, int pnum) } /* Write a pattern and check it */ - memset(ubi->peb_buf1, patterns[i], ubi->peb_size); - err = ubi_io_write(ubi, ubi->peb_buf1, pnum, 0, ubi->peb_size); + memset(ubi->peb_buf, patterns[i], ubi->peb_size); + err = ubi_io_write(ubi, ubi->peb_buf, pnum, 0, ubi->peb_size); if (err) goto out; - memset(ubi->peb_buf1, ~patterns[i], ubi->peb_size); - err = ubi_io_read(ubi, ubi->peb_buf1, pnum, 0, ubi->peb_size); + memset(ubi->peb_buf, ~patterns[i], ubi->peb_size); + err = ubi_io_read(ubi, ubi->peb_buf, pnum, 0, ubi->peb_size); if (err) goto out; - err = ubi_check_pattern(ubi->peb_buf1, patterns[i], + err = ubi_check_pattern(ubi->peb_buf, patterns[i], ubi->peb_size); if (err == 0) { ubi_err("pattern %x checking failed for PEB %d", diff --git a/drivers/mtd/ubi/scan.c b/drivers/mtd/ubi/scan.c index b99318e..12c43b4 100644 --- a/drivers/mtd/ubi/scan.c +++ b/drivers/mtd/ubi/scan.c @@ -789,9 +789,9 @@ static int check_corruption(struct ubi_device *ubi, struct ubi_vid_hdr *vid_hdr, int err; mutex_lock(&ubi->buf_mutex); - memset(ubi->peb_buf1, 0x00, ubi->leb_size); + memset(ubi->peb_buf, 0x00, ubi->leb_size); - err = ubi_io_read(ubi, ubi->peb_buf1, pnum, ubi->leb_start, + err = ubi_io_read(ubi, ubi->peb_buf, pnum, ubi->leb_start, ubi->leb_size); if (err == UBI_IO_BITFLIPS || mtd_is_eccerr(err)) { /* @@ -808,7 +808,7 @@ static int check_corruption(struct ubi_device *ubi, struct ubi_vid_hdr *vid_hdr, if (err) goto out_unlock; - if (ubi_check_pattern(ubi->peb_buf1, 0xFF, ubi->leb_size)) + if (ubi_check_pattern(ubi->peb_buf, 0xFF, ubi->leb_size)) goto out_unlock; ubi_err("PEB %d contains corrupted VID header, and the data does not " @@ -818,7 +818,7 @@ static int check_corruption(struct ubi_device *ubi, struct ubi_vid_hdr *vid_hdr, dbg_msg("hexdump of PEB %d offset %d, length %d", pnum, ubi->leb_start, ubi->leb_size); ubi_dbg_print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1, - ubi->peb_buf1, ubi->leb_size, 1); + ubi->peb_buf, ubi->leb_size, 1); err = 1; out_unlock: diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h index cb93ad9..bd6120c 100644 --- a/drivers/mtd/ubi/ubi.h +++ b/drivers/mtd/ubi/ubi.h @@ -387,8 +387,8 @@ struct ubi_wl_entry; * time (MTD write buffer size) * @mtd: MTD device descriptor * - * @peb_buf1: a buffer of PEB size used for different purposes - * @buf_mutex: protects @peb_buf1 + * @peb_buf: a buffer of PEB size used for different purposes + * @buf_mutex: protects @peb_buf * @ckvol_mutex: serializes static volume checking when opening * * @dbg: debugging information for this UBI device @@ -470,7 +470,7 @@ struct ubi_device { int max_write_size; struct mtd_info *mtd; - void *peb_buf1; + void *peb_buf; struct mutex buf_mutex; struct mutex ckvol_mutex; -- 1.7.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] UBI: allocate verification buffer on demand 2012-03-08 14:14 [PATCH 1/2] UBI: allocate verification buffer on demand Artem Bityutskiy 2012-03-08 14:14 ` [PATCH 2/2] UBI: rename peb_buf1 to peb_buf Artem Bityutskiy @ 2012-03-08 16:08 ` Shmulik Ladkani 2012-03-09 7:45 ` Artem Bityutskiy 1 sibling, 1 reply; 6+ messages in thread From: Shmulik Ladkani @ 2012-03-08 16:08 UTC (permalink / raw) To: Artem Bityutskiy; +Cc: Josselin Costanzi, MTD Maling List On Thu, 8 Mar 2012 16:14:50 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote: > From: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> > > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. > The only reason UBI has it is to check that the data were written correctly. > But we do not have to have 2 buffers for this and waste RAM - we can just > compare CRC checksums instead. > > Artem bityutskiy: massaged the patch and commit message > > Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Josselin's original title "allocate verification buffer on demand" does no longer describe this patch. Should be "Remove the pre-allocated 'peb_buf2'" or alike. Regards, Shmulik ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] UBI: allocate verification buffer on demand 2012-03-08 16:08 ` [PATCH 1/2] UBI: allocate verification buffer on demand Shmulik Ladkani @ 2012-03-09 7:45 ` Artem Bityutskiy 2012-03-09 9:13 ` Josselin Costanzi 0 siblings, 1 reply; 6+ messages in thread From: Artem Bityutskiy @ 2012-03-09 7:45 UTC (permalink / raw) To: Shmulik Ladkani; +Cc: Josselin Costanzi, MTD Maling List On Thu, 2012-03-08 at 18:08 +0200, Shmulik Ladkani wrote: > On Thu, 8 Mar 2012 16:14:50 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote: > > From: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> > > > > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. > > The only reason UBI has it is to check that the data were written correctly. > > But we do not have to have 2 buffers for this and waste RAM - we can just > > compare CRC checksums instead. > > > > Artem bityutskiy: massaged the patch and commit message > > > > Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> > > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > Josselin's original title "allocate verification buffer on demand" does > no longer describe this patch. > Should be "Remove the pre-allocated 'peb_buf2'" or alike. Fixed as well and pushed out, thanks! Waiting for Josselin's reply anyway. commit 43b043e78b876ce27034f167897b57fd2556ad29 Author: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> Date: Wed Feb 22 16:37:05 2012 +0100 UBI: reduce memory consumption Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. The only reason UBI has it is to check that the data were written correctly. But we do not have to have 2 buffers for this and waste RAM - we can just compare CRC checksums instead. This reduces UBI memory consumption. Artem bityutskiy: massaged the patch and commit message Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> -- Best Regards, Artem Bityutskiy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] UBI: allocate verification buffer on demand 2012-03-09 7:45 ` Artem Bityutskiy @ 2012-03-09 9:13 ` Josselin Costanzi 2012-03-09 16:42 ` Josselin Costanzi 0 siblings, 1 reply; 6+ messages in thread From: Josselin Costanzi @ 2012-03-09 9:13 UTC (permalink / raw) To: dedekind1; +Cc: MTD Maling List, Shmulik Ladkani 2012/3/9 Artem Bityutskiy <dedekind1@gmail.com>: > On Thu, 2012-03-08 at 18:08 +0200, Shmulik Ladkani wrote: >> On Thu, 8 Mar 2012 16:14:50 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote: >> > From: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> >> > >> > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. >> > The only reason UBI has it is to check that the data were written correctly. >> > But we do not have to have 2 buffers for this and waste RAM - we can just >> > compare CRC checksums instead. >> > >> > Artem bityutskiy: massaged the patch and commit message >> > >> > Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> >> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> >> >> Josselin's original title "allocate verification buffer on demand" does >> no longer describe this patch. >> Should be "Remove the pre-allocated 'peb_buf2'" or alike. > > Fixed as well and pushed out, thanks! Waiting for Josselin's reply > anyway. I will try to find time to test your patches today and will give my feedback ASAP > commit 43b043e78b876ce27034f167897b57fd2556ad29 > Author: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> > Date: Wed Feb 22 16:37:05 2012 +0100 > > UBI: reduce memory consumption > > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. > The only reason UBI has it is to check that the data were written correctly. > But we do not have to have 2 buffers for this and waste RAM - we can just > compare CRC checksums instead. This reduces UBI memory consumption. > > Artem bityutskiy: massaged the patch and commit message > > Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > > -- > Best Regards, > Artem Bityutskiy > -- Josselin Costanzi Embedded Linux System Engineer Tél. : +33 (0) 1 42 11 93 25 Fax: +33 (0) 1 42 11 87 17 Warning This message (and any associated files) is intended only for the use of its intended recipient and may contain information that is confidential, subject to copyright or constitutes a trade secret. If you are not the intended recipient you are hereby notified that any dissemination, copying or distribution of this message, or files associated with this message, is strictly prohibited. If you have received this message in error, please notify us immediately by replying to the message and deleting it from your computer. Any views or opinions presented are solely those of the author josselin.costanzi@mobile-devices.fr and do not necessarily represent those of the company. Although the company has taken reasonable precautions to ensure no viruses are present in this email, the company cannot accept responsibility for any loss or damage arising from the use of this email or attachments. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] UBI: allocate verification buffer on demand 2012-03-09 9:13 ` Josselin Costanzi @ 2012-03-09 16:42 ` Josselin Costanzi 0 siblings, 0 replies; 6+ messages in thread From: Josselin Costanzi @ 2012-03-09 16:42 UTC (permalink / raw) To: dedekind1; +Cc: MTD Maling List, Shmulik Ladkani 2012/3/9 Josselin Costanzi <josselin.costanzi@mobile-devices.fr>: > 2012/3/9 Artem Bityutskiy <dedekind1@gmail.com>: >> On Thu, 2012-03-08 at 18:08 +0200, Shmulik Ladkani wrote: >>> On Thu, 8 Mar 2012 16:14:50 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote: >>> > From: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> >>> > >>> > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. >>> > The only reason UBI has it is to check that the data were written correctly. >>> > But we do not have to have 2 buffers for this and waste RAM - we can just >>> > compare CRC checksums instead. >>> > >>> > Artem bityutskiy: massaged the patch and commit message >>> > >>> > Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> >>> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> >>> >>> Josselin's original title "allocate verification buffer on demand" does >>> no longer describe this patch. >>> Should be "Remove the pre-allocated 'peb_buf2'" or alike. >> >> Fixed as well and pushed out, thanks! Waiting for Josselin's reply >> anyway. > I will try to find time to test your patches today and will give my > feedback ASAP I'm okay with your version of the patch. Thanks. >> commit 43b043e78b876ce27034f167897b57fd2556ad29 >> Author: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> >> Date: Wed Feb 22 16:37:05 2012 +0100 >> >> UBI: reduce memory consumption >> >> Remove the pre-allocated 'peb_buf2' buffer because we do not really need it. >> The only reason UBI has it is to check that the data were written correctly. >> But we do not have to have 2 buffers for this and waste RAM - we can just >> compare CRC checksums instead. This reduces UBI memory consumption. >> >> Artem bityutskiy: massaged the patch and commit message >> >> Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr> >> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> >> >> >> -- >> Best Regards, >> Artem Bityutskiy >> > > > > -- > Josselin Costanzi > Embedded Linux System Engineer > > Tél. : +33 (0) 1 42 11 93 25 > Fax: +33 (0) 1 42 11 87 17 > > > Warning > This message (and any associated files) is intended only for the use > of its intended recipient and may contain information that is > confidential, subject to copyright or constitutes a trade secret. If > you are not the intended recipient you are hereby notified that any > dissemination, copying or distribution of this message, or files > associated with this message, is strictly prohibited. If you have > received this message in error, please notify us immediately by > replying to the message and deleting it from your computer. Any views > or opinions presented are solely those of the author > josselin.costanzi@mobile-devices.fr and do not necessarily represent > those of the company. Although the company has taken reasonable > precautions to ensure no viruses are present in this email, the > company cannot accept responsibility for any loss or damage arising > from the use of this email or attachments. -- Josselin Costanzi Embedded Linux System Engineer ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-09 16:43 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-03-08 14:14 [PATCH 1/2] UBI: allocate verification buffer on demand Artem Bityutskiy 2012-03-08 14:14 ` [PATCH 2/2] UBI: rename peb_buf1 to peb_buf Artem Bityutskiy 2012-03-08 16:08 ` [PATCH 1/2] UBI: allocate verification buffer on demand Shmulik Ladkani 2012-03-09 7:45 ` Artem Bityutskiy 2012-03-09 9:13 ` Josselin Costanzi 2012-03-09 16:42 ` Josselin Costanzi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox