From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Huang Shijie <b32955@freescale.com>
Cc: Vinod Koul <vinod.koul@linux.intel.com>,
Fabio Estevam <festevam@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
linux-mtd@lists.infradead.org,
Shawn Guo <shawn.guo@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>,
Sam Gandhi <samgandhi9@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Using GPMI-NAND driver on iMX28 using 3.4-rc1?
Date: Tue, 10 Apr 2012 10:42:23 +0100 [thread overview]
Message-ID: <20120410094223.GN24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4F7EC6AF.6000603@freescale.com>
On Fri, Apr 06, 2012 at 06:34:23PM +0800, Huang Shijie wrote:
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index 5978113..0f5b09a 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -202,10 +202,12 @@ static struct mxs_dma_chan *to_mxs_dma_chan(struct
> dma_cha
> static dma_cookie_t mxs_dma_tx_submit(struct dma_async_tx_descriptor *tx)
> {
> struct mxs_dma_chan *mxs_chan = to_mxs_dma_chan(tx->chan);
> + dma_cookie_t c;
>
> + c = dma_cookie_assign(tx);
> mxs_dma_enable_chan(mxs_chan);
>
> - return dma_cookie_assign(tx);
> + return c;
Hang on, why are you enabling a channel (and presumably allowing this
transaction to be issued) before dma_async_issue_pending() has been
called for the channel?
next prev parent reply other threads:[~2012-04-10 9:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 6:05 Using GPMI-NAND driver on iMX28 using 3.4-rc1? Sam Gandhi
2012-04-04 7:01 ` Wolfram Sang
2012-04-04 18:08 ` Sam Gandhi
2012-04-04 18:33 ` Wolfram Sang
2012-04-04 20:27 ` Sam Gandhi
2012-04-04 20:55 ` Fabio Estevam
2012-04-04 22:07 ` Sam Gandhi
2012-04-04 22:28 ` Fabio Estevam
2012-04-05 3:00 ` Huang Shijie
2012-04-05 6:37 ` Huang Shijie
2012-04-05 12:03 ` Sam Gandhi
2012-04-05 12:27 ` Vinod Koul
2012-04-05 13:02 ` Sam Gandhi
2012-04-05 13:48 ` Vinod Koul
2012-04-05 14:38 ` Sam Gandhi
2012-04-06 2:23 ` Shawn Guo
2012-04-06 2:45 ` Huang Shijie
2012-04-06 3:45 ` Shawn Guo
2012-04-06 10:34 ` Huang Shijie
2012-04-06 12:49 ` Shawn Guo
2012-04-06 13:49 ` Sam Gandhi
2012-04-06 13:59 ` Shawn Guo
2012-04-06 14:06 ` Sam Gandhi
2012-04-06 14:21 ` Shawn Guo
2012-04-06 14:53 ` Sam Gandhi
2012-04-10 9:42 ` Russell King - ARM Linux [this message]
2012-04-10 12:39 ` Shawn Guo
2012-04-10 12:47 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410094223.GN24211@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=b32955@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=samgandhi9@gmail.com \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox