From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Vinod Koul <vinod.koul@linux.intel.com>,
Fabio Estevam <festevam@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org,
Shawn Guo <shawn.guo@freescale.com>,
Sam Gandhi <samgandhi9@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Using GPMI-NAND driver on iMX28 using 3.4-rc1?
Date: Tue, 10 Apr 2012 13:47:21 +0100 [thread overview]
Message-ID: <20120410124721.GS24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120410123952.GA419@S2101-09.ap.freescale.net>
On Tue, Apr 10, 2012 at 08:39:58PM +0800, Shawn Guo wrote:
> When mxs-dma driver was created, we chose to only support a single
> descriptor at the beginning, and mxs_dma_issue_pending() is an empty
> function right now . This is something needs to be improved, but it
> should be orthogonal to the bug fix posted here.
You could view it as being the reason that the bug occurred, because
had the issue_pending() function been used to start the transfer,
things would naturally happen in the right order.
So, one solution to the bug would be to do exactly that - move the
channel enable to the issue pending function, which will have the
same effect as reversing the order of cookie assignment and channel
enable.
However, the risk is that because you have a no-op issue_pending(),
some of your drivers may have decided its not worth calling and omitted
it.
prev parent reply other threads:[~2012-04-10 12:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 6:05 Using GPMI-NAND driver on iMX28 using 3.4-rc1? Sam Gandhi
2012-04-04 7:01 ` Wolfram Sang
2012-04-04 18:08 ` Sam Gandhi
2012-04-04 18:33 ` Wolfram Sang
2012-04-04 20:27 ` Sam Gandhi
2012-04-04 20:55 ` Fabio Estevam
2012-04-04 22:07 ` Sam Gandhi
2012-04-04 22:28 ` Fabio Estevam
2012-04-05 3:00 ` Huang Shijie
2012-04-05 6:37 ` Huang Shijie
2012-04-05 12:03 ` Sam Gandhi
2012-04-05 12:27 ` Vinod Koul
2012-04-05 13:02 ` Sam Gandhi
2012-04-05 13:48 ` Vinod Koul
2012-04-05 14:38 ` Sam Gandhi
2012-04-06 2:23 ` Shawn Guo
2012-04-06 2:45 ` Huang Shijie
2012-04-06 3:45 ` Shawn Guo
2012-04-06 10:34 ` Huang Shijie
2012-04-06 12:49 ` Shawn Guo
2012-04-06 13:49 ` Sam Gandhi
2012-04-06 13:59 ` Shawn Guo
2012-04-06 14:06 ` Sam Gandhi
2012-04-06 14:21 ` Shawn Guo
2012-04-06 14:53 ` Sam Gandhi
2012-04-10 9:42 ` Russell King - ARM Linux
2012-04-10 12:39 ` Shawn Guo
2012-04-10 12:47 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410124721.GS24211@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=b32955@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=samgandhi9@gmail.com \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox