From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Grant Edwards <grant.b.edwards@gmail.com>,
Ricard Wanderlof <ricard.wanderlof@axis.com>,
dedekind1@gmail.com
Subject: [PATCH] mtd-utils: Better document --pagesize of mkfs.jffs2
Date: Thu, 3 May 2012 21:59:59 +0300 [thread overview]
Message-ID: <20120503215959.374d0c34@halley> (raw)
Add a strict explanation '--pagesize' refers to target system's mm page
size.
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
---
This is according to the below discussion:
http://lists.infradead.org/pipermail/linux-mtd/2012-May/041233.html
diff --git a/mkfs.jffs2.1 b/mkfs.jffs2.1
index 9b0acc3..47a3ac7 100644
--- a/mkfs.jffs2.1
+++ b/mkfs.jffs2.1
@@ -137,7 +137,8 @@ directory.
.TP
.B -s, --pagesize=SIZE
Use page size SIZE. The default is 4 KiB. This size is the
-maximum size of a data node.
+maximum size of a data node. Set according to target system's memory
+management page size (NOTE: this is NOT related to NAND page size).
.TP
.B -e, --eraseblock=SIZE
Use erase block size SIZE. The default is 64 KiB. If you use a erase
diff --git a/mkfs.jffs2.c b/mkfs.jffs2.c
index ad88ac6..d170a04 100644
--- a/mkfs.jffs2.c
+++ b/mkfs.jffs2.c
@@ -1391,7 +1391,9 @@ static const char helptext[] =
" not specified, the output is padded to the end of\n"
" the final erase block\n"
" -r, -d, --root=DIR Build file system from directory DIR (default: cwd)\n"
-" -s, --pagesize=SIZE Use page size (max data node size) SIZE (default: 4KiB)\n"
+" -s, --pagesize=SIZE Use page size (max data node size) SIZE.\n"
+" Set according to target system's memory management\n"
+" page size (default: 4KiB)\n"
" -e, --eraseblock=SIZE Use erase block size SIZE (default: 64KiB)\n"
" -c, --cleanmarker=SIZE Size of cleanmarker (default 12)\n"
" -m, --compr-mode=MODE Select compression mode (default: priortiry)\n"
next reply other threads:[~2012-05-03 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 18:59 Shmulik Ladkani [this message]
2012-05-04 8:29 ` [PATCH] mtd-utils: Better document --pagesize of mkfs.jffs2 Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503215959.374d0c34@halley \
--to=shmulik.ladkani@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grant.b.edwards@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox