public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-mtd@lists.infradead.org
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Mike Dunn <mikedunn@newsguy.com>
Subject: flash bbt broken due to unitialized bitflip_threshold?
Date: Wed, 6 Jun 2012 00:06:47 +0200	[thread overview]
Message-ID: <20120605220647.GV30400@pengutronix.de> (raw)

Hi All,

nand_scan_tail calls chip->scan_bbt which in case of a flash based bbt
calls mtd_read. mtd_read returns -EUCLEAN when the number of errors
exceeds bitflip_threshold. The problem is that bitflip_threshold is
uninitialized at that time, it is initialized in add_mtd_device which is
called after nand_scan. This is seen on the mxc_nand controller, but
probably on other drivers aswell.

Am I missing something?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

             reply	other threads:[~2012-06-05 22:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05 22:06 Sascha Hauer [this message]
2012-06-06  9:50 ` flash bbt broken due to unitialized bitflip_threshold? Shmulik Ladkani
2012-06-06 13:30   ` Artem Bityutskiy
2012-06-06 15:15     ` Shmulik Ladkani
2012-06-06 15:46       ` Artem Bityutskiy
2012-06-06 16:08         ` Shmulik Ladkani
2012-06-06 17:55         ` Ivan Djelic
2012-06-07  7:36           ` Artem Bityutskiy
2012-06-07 14:02             ` Shmulik Ladkani
2012-06-07 17:34             ` Mike Dunn
2012-06-07 21:07               ` Shmulik Ladkani
2012-06-10  7:08               ` Shmulik Ladkani
2012-06-22 20:39                 ` Brian Norris
2012-06-25 17:44                   ` Mike Dunn
2012-06-07  7:43           ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120605220647.GV30400@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mikedunn@newsguy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox